WIP Fix in-place tensor mutation when sharding #290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This depends on iree-org/iree-turbine#220 |
Add option to construct sharded tensors without inserting device placement operations. Add a simple test for in-place addition t += 1 When unflattening a sharded tensor during exporting insert in-place device placements, which get translated to function argument affinity attributes.
sogartar
force-pushed
the
llama-missing-cache-export
branch
from
2605f1e
to
36ca12f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add option to construct sharded tensors without inserting device placement operations.
Add a simple test for in-place addition
t += 1
It exports and runs on IREE.
When unflattening a sharded tensor during exporting insert in-place device placements, which get translated to function argument affinity attributes.