Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a flag to select between nondecomposed and decomposed attention #296

Merged
merged 18 commits into from
Oct 23, 2024
Merged

Add a flag to select between nondecomposed and decomposed attention #296

merged 18 commits into from
Oct 23, 2024

Conversation

KyleHerndon
Copy link
Contributor

No description provided.

dan-garvey
dan-garvey reviewed Oct 23, 2024
View reviewed changes
Copy link
Member

@dan-garvey dan-garvey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor comments

sharktank/sharktank/export_layer/export_paged_attention.py Show resolved Hide resolved
sharktank/sharktank/ops/default_impls.py Outdated Show resolved Hide resolved
@KyleHerndon KyleHerndon enabled auto-merge (squash) October 23, 2024 21:19
@KyleHerndon KyleHerndon merged commit 73c830e into main Oct 23, 2024
3 checks passed
@KyleHerndon KyleHerndon deleted the ndc branch October 23, 2024 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dan-garvey dan-garvey dan-garvey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KyleHerndon @dan-garvey