[sharktank] Evaluation - Add Perplexity test for vmfb #306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tform into perplexity-vmfb
IanNod
reviewed
Oct 24, 2024
…tform into perplexity-vmfb
…tform into perplexity-vmfb
IanNod
approved these changes
Oct 28, 2024
…tform into perplexity-vmfb
sogartar
reviewed
Oct 30, 2024
| token_batch, | ||
| self.seq_lens_batch, | ||
| seq_block_ids, | ||
| self.batch.cache_state[0].to(torch.float16), |
There was a problem hiding this comment.
@archana-ramalingam, I think this may make a copy.
First the .to(...) may make a copy.
Then before the making the actual call to the IREE module function it will make a copy to the device if we are not targeting the CPU.
There was a problem hiding this comment.
You would need to first explicitly make a iree.runtime.DeviceArray and then copy back to the cache state after the call.
I have also added some IREE related functionality here. We should unify this aspect to reduce code duplication.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Perplexity test for vmfb