[shortfin] Add dev_me.py script to standardize my development process. #335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will land and iterate as it starts to meet my needs. |
ScottTodd
reviewed
Oct 29, 2024
Comment on lines
+44
to
+46
| CMAKE_REQUIRED_VERSION = Version("3.29") | ||
| PYTHON_REQUIRED_VERSION = Version("3.12") | ||
| CLANG_REQUIRED_VERSION = Version("16") |
There was a problem hiding this comment.
Are these minimum versions, or exact versions?
Comment on lines
+133
to
+138
| if self.clang_exe and self.clang_version < CLANG_REQUIRED_VERSION: | ||
| print(f"ERROR: clang version too old: {self.clang_exe}") | ||
| print(f" REQUIRED: {CLANG_REQUIRED_VERSION}, Found {self.clang_version}") | ||
| elif not self.clang_exe: | ||
| print(f"WARNING: Building the project with clang is highly recommended") | ||
| print(f" (pass --clang= to select clang)") |
There was a problem hiding this comment.
Would be nice to support MSVC on Windows here too, without warnings.
| actual_env_vars = dict(os.environ) | ||
| actual_env_vars.update(env_vars) | ||
| subprocess.check_call(setup_args, cwd=env_info.this_dir, env=actual_env_vars) | ||
| print("You are now DEV'd!") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.