Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[shortfin] Adds C++ tracing scopes. #480

Merged
merged 1 commit into from
Nov 12, 2024
Merged

[shortfin] Adds C++ tracing scopes. #480

merged 1 commit into from
Nov 12, 2024

Conversation

stellaraccident
Copy link
Contributor

  • Manually chose a number of things that would be interesting to see in a trace and added annotations.
  • QC'd with some unit test traces.

@stellaraccident
[shortfin] Adds C++ tracing scopes.
7477d4a 
* Manually chose a number of things that would be interesting to see in a trace and added annotations.
* QC'd with some unit test traces.
monorimet
monorimet approved these changes Nov 12, 2024
View reviewed changes
Copy link
Contributor

@monorimet monorimet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@stellaraccident stellaraccident merged commit 35bc60d into main Nov 12, 2024
11 of 13 checks passed
@stellaraccident stellaraccident deleted the shortfin_tracing branch November 12, 2024 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@monorimet monorimet monorimet approved these changes

@ScottTodd ScottTodd ScottTodd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stellaraccident @ScottTodd @monorimet