Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix workflows installing nightly IREE packages to use --pre. #506

Merged
merged 3 commits into from
Nov 14, 2024

Conversation

ScottTodd
Copy link
Member

Pip will only install "pre-release" versions if --pre is set or the version is set explicitly: https://pip.pypa.io/en/stable/cli/pip_install/#pre-release-versions. The rc part of our rcYYYYMMDD suffix used in the nightly IREE packages is considered a "Pre-release segment" in the version string: https://packaging.python.org/en/latest/specifications/version-specifiers/#public-version-identifiers.

This should change workflow jobs like https://github.com/nod-ai/SHARK-Platform/actions/runs/11827078971/job/32954462017#step:5:163 that have been downloading iree-base-compiler-2.9.0 iree-base-runtime-2.9.0 to downloading the latest nightly versions instead, as they intend:

# Update to the latest iree packages.
pip install -f https://iree.dev/pip-release-links.html --upgrade \
iree-base-compiler iree-base-runtime --src deps \
-e "git+https://github.com/iree-org/iree-turbine.git#egg=iree-turbine"

@ScottTodd ScottTodd marked this pull request as ready for review November 14, 2024 00:27
Copy link
Collaborator

@marbre marbre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this Scott! Tested locally.

@ScottTodd ScottTodd merged commit f429c91 into nod-ai:main Nov 14, 2024
6 checks passed
@ScottTodd ScottTodd deleted the pip-pre branch November 14, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants