-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use dev_me.py for shortfin integration tests #527
Conversation
- name: Install shortfin via dev_me.py | ||
run: cd shortfin && python dev_me.py |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally integration tests would use built packages, so they can't assume anything about the source environment. Developer scripts could still be used for unit tests though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh good point. Will take the setup section and swap it into a unit test once done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IDK what you're doing with the git clone stuff, but I also want more workflows to just use the FetchContent
code in CMake that downloads automatically. Developer flows and GitHub Actions should both be simple. Branchy bash scripts that peek at output from pip commands are not simple :P
dev_me.py appears to handle the automatic download case:
SHARK-Platform/shortfin/dev_me.py
Lines 29 to 31 in 778b567
# By default, if there is an iree source dir adjacent to this parent repository, | |
# that will be used (so you can just directly edit IREE runtime code and build. | |
# Otherwise, the shortfin build will download a pinned IREE source tree. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just trying to not repeatedly download code - - i was also trying to make this integration test faster
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(now that i look at it iree_repo_dir already seems to cache the iree repo for the unittests; might get that over so that shortfin build doesn't have to pull iree)
closing because didn't find the low hanging fruits i wanted to find : / |
No description provided.