Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use dev_me.py for shortfin integration tests #527

Closed
wants to merge 8 commits into from

Conversation

renxida
Copy link
Contributor

@renxida renxida commented Nov 14, 2024

No description provided.

Comment on lines 86 to 87
- name: Install shortfin via dev_me.py
run: cd shortfin && python dev_me.py
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally integration tests would use built packages, so they can't assume anything about the source environment. Developer scripts could still be used for unit tests though.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh good point. Will take the setup section and swap it into a unit test once done.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IDK what you're doing with the git clone stuff, but I also want more workflows to just use the FetchContent code in CMake that downloads automatically. Developer flows and GitHub Actions should both be simple. Branchy bash scripts that peek at output from pip commands are not simple :P

dev_me.py appears to handle the automatic download case:

# By default, if there is an iree source dir adjacent to this parent repository,
# that will be used (so you can just directly edit IREE runtime code and build.
# Otherwise, the shortfin build will download a pinned IREE source tree.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just trying to not repeatedly download code - - i was also trying to make this integration test faster

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(now that i look at it iree_repo_dir already seems to cache the iree repo for the unittests; might get that over so that shortfin build doesn't have to pull iree)

@renxida
Copy link
Contributor Author

renxida commented Nov 15, 2024

closing because didn't find the low hanging fruits i wanted to find : /

@renxida renxida closed this Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants