Group llm integration test output using github ::group:: #546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renxida
changed the title
renxida
force-pushed
the
integration-test-granular-steps
branch
from
795e8f9
to
aa729f0
Compare
renxida
changed the title
stbaione
reviewed
Nov 15, 2024
| expected_output_prefix = "6 7 8" | ||
| logger.info("::group::Sending HTTP Generation Request") |
There was a problem hiding this comment.
Was this also supposed to create it's own group?
Looks like it needs an ::endgroup at the end, with logging the output:
INFO app_tests.integration_tests.llm.cpu_llm_server_test:cpu_llm_server_test.py:87 ::group::Sending HTTP Generation Request
INFO app_tests.integration_tests.llm.cpu_llm_server_test:cpu_llm_server_test.py:35 Generating request...
INFO app_tests.integration_tests.llm.cpu_llm_server_test:cpu_llm_server_test.py:48 Prompt text:
INFO app_tests.integration_tests.llm.cpu_llm_server_test:cpu_llm_server_test.py:49 1 2 3 4 5
INFO app_tests.integration_tests.llm.cpu_llm_server_test:cpu_llm_server_test.py:52 Generate endpoint status code: 200
INFO app_tests.integration_tests.llm.cpu_llm_server_test:cpu_llm_server_test.py:54 Generated text:
INFO app_tests.integration_tests.llm.cpu_llm_server_test:cpu_llm_server_test.py:96 6 7 8 9 10 11 12
stbaione
reviewed
Nov 15, 2024
| @@ -24,6 +24,20 @@ | |||
| logger = logging.getLogger(__name__) | |||
|
|
|||
|
|
|||
| def ghstartgroup(msg): | |||
There was a problem hiding this comment.
This and ghendgroup may be more shareable with model setup and the actual test if it was in utils.py.
We already import from utils in conftest and would make it so that we could easily reuse it in the integration test, instead of hardcoding a ::group::/::endgroup:: tag
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the ::group:: GitHub Workflow Command to make it easier to navigate integration logs.
Also adds a summary to easily look at what the generation results are.