Patch SGL Benchmark Test for Pytest Dashboard #551
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The nightly SGLang benchmark tests had first successful run last night: https://github.com/nod-ai/shark-ai/actions/runs/11850084805/job/33024395622
And uploaded to dashboard successfully: https://nod-ai.github.io/shark-ai/llm/sglang/?sort=result
However, since I used a mock to pipe the
bench_serving
script output tologger.info
, we ended up with results appearing in runner log, that did not appear in dashboard:It also had a small bug that was obfuscated in runner/terminal logs, but appeared in dashboard, which prevented jsonl files from being generated after benchmark results were collected.
By fixing the bug in bench_serving input args, and logging resulting jsonl file after each run, I was able to verify locally that the output html contains the proper results: