Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up validate_llama_ref_model example and requirements for examples #6

Merged
merged 2 commits into from
May 3, 2024

Conversation

aviator19941
Copy link
Collaborator

@aviator19941 aviator19941 commented Apr 24, 2024

huggingface-hub is needed for hf_datasets.py and transformers is needed for AutoTokenizer

huggingface-hub==0.22.2
transformers==4.40.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran into this also.

Do we want these added at the top level here, or included optionally?

Comment on lines 15 to +16
from ...layers import *
from ...types import Theta
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also just ran into this too... can we get some of these PRs merged?

@stellaraccident
Copy link
Contributor

Please resolve conflicts and land. Can get reviews and land with peers on the team. Doesn't need to wait on me

@aviator19941 aviator19941 merged commit 6cec32e into nod-ai:main May 3, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants