Message Tracing by metric log #34
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knolleary
reviewed
Jul 23, 2020
designs/message-trace/README.md
Outdated
| - msg: message in process. For example, when join node send a concatenated message, use the message as an argument of `node.metric()`. | ||
| - relatedMsgIds: array of ids of related messages. | ||
|
|
||
| Note: we can put more complex information on the third argument of `node.metric()`. For example, we can make it a object which contains a array of message ids and a relation type such as `"isPartOf"`, `"splitInto"`, `"isDependsOn"`, etc. |
There was a problem hiding this comment.
I think we need to decide if it's going to be a more complex object from the start - it isn't something we can change later.
In the Join node scenario, which is the main scenario that requires this correlate metric, I would suggest it looks like:
{ "join":["A", "B", "C" ...]}
That gives us room to introduce other correlate messages if they prove necessary.
|
Updated according to comment #34 (comment).
|
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This design note proposes extension of metric log so that we can trace messages.
Part of message trace function can be implemented in 'Pluggable Message Routing', but runtime can't recognize a relationship between messages (e.g. in join node, runtime can't know which messages are combined into another message).