Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lookup: add React #1059

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

lookup: add React #1059

wants to merge 1 commit into from

Conversation

targos
Copy link
Member

@targos targos commented May 9, 2024

Closes: #1038

I looked at https://github.com/facebook/react/blob/main/.circleci/config.yml to prepare a first draft.

@targos
Copy link
Member Author

targos commented May 9, 2024

@targos
Copy link
Member Author

targos commented May 9, 2024

It refuses to run tests on unsupported versions of Node.js, which won't help to find regressions.

error:                     | AssertionError [ERR_ASSERTION]: Current node version is not supported for development, expected "22.1.0" to satisfy "16.x || 18.x || 20.x || 21.x".                                                                        
error:                     | at Object.<anonymous> (/tmp/6f82fd48-e79e-4aab-a0bf-d5226b5f47d0/react/node_modules/fbjs-scripts/node/check-dev-engines.js:46:3)   

@codecov-commenter
Copy link

codecov-commenter commented May 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.74%. Comparing base (12e6902) to head (6ed37c2).
Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1059      +/-   ##
==========================================
- Coverage   96.35%   92.74%   -3.61%     
==========================================
  Files          29       29              
  Lines        2192     2192              
==========================================
- Hits         2112     2033      -79     
- Misses         80      159      +79     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@targos
Copy link
Member Author

targos commented May 9, 2024

One test fails on Node.js 18 and 20.
Node.js 21 fails because global.navigator is not writable.

@targos targos mentioned this pull request May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add react to the CITGM
2 participants