lookup: re-add fastify

[mcollina]

No description provided.

[mcollina]

@Trott how can I test this in CITGM smoker?

[Trott]

@Trott how can I test this in CITGM smoker?

EDIT: It looks like the below stuff didn't work so I guess I didn't quite get it right. The GIT_REMOTE_REF probably refers to the nodejs/node repository and not the nodejs/citgm repository.....

If I didn't make any mistakes, it's running here: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/3227/

Here are the steps I took to do it:

1. Go to https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/.
2. Select "Build With Parameters" on the left.
3. Enter refs/pull/973/head for the GIT_REMOTE_REF
4. Enter citgm fastify for the CITGM_COMMAND (so that it only runs a test for fastify and not every module in lookup.json)
5. Use the Build button

[Trott]

@Trott how can I test this in CITGM smoker?

EDIT: It looks like the below stuff didn't work so I guess I didn't quite get it right. The GIT_REMOTE_REF probably refers to the nodejs/node repository and not the nodejs/citgm repository....

Maybe someone on @nodejs/citgm knows the right thing to do to test this PR?

[targos]

https://github.com/nodejs/citgm/actions/runs/6148435347

I used https://github.com/nodejs/citgm/actions/workflows/test-module.yml

[richardlau]

@Trott how can I test this in CITGM smoker?

EDIT: It looks like the below stuff didn't work so I guess I didn't quite get it right. The GIT_REMOTE_REF probably refers to the nodejs/node repository and not the nodejs/citgm repository....

Maybe someone on @nodejs/citgm knows the right thing to do to test this PR?

If you want to use the Jenkins job, use the CITGM parameter:

e.g. for this PR, try nodejs/citgm#fastify-fix.

[targos]

New run passed: https://github.com/nodejs/citgm/actions/runs/6148435347

[mcollina]

Let's see what the smoker says: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/3230/.

[mcollina]

Fresh CITGM: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/3255/

[codecov-commenter]

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (b8193a7) 96.44% compared to head (9db7bc9) 96.44%.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #973   +/-   ##
=======================================
  Coverage   96.44%   96.44%           
=======================================
  Files          28       28           
  Lines        2139     2139           
=======================================
  Hits         2063     2063           
  Misses         76       76           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[mcollina]

Fresh CITGM: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/3272/

[richardlau]

Suggested change

	"skip": ["s390x", "aix", "aix72-ppc64"],
	"skip": ["s390x", "aix"],

You don't need aix72-ppc64 if aix is also in this set. Skips are only considered for citgm-all -- if you're running citgm <module> CITGM assumes you wanted to run for that module.

[mcollina]

Ah awesome, so I don't need a full green run.

[simone-sanfratello]

Hello, I'm investigating the failing tests, tackling one by one.

For example this one

https://github.com/fastify/fastify/blob/main/test/custom-http-server.test.js#L11

Looks like it gets timeout on dns lookup

const localAddresses = await dns.lookup('localhost', { all: true })

I'm adding more logs to get information, btw, what the dns lookup is suppose to return in those machines?

[mcollina]

https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/3313/

[mcollina]

CITGM: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/3326/

[mcollina]

CITGM: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/3335/

[mcollina]

@targos can you confirm everything is passing correctly? I think we got there eventually.

[targos]

LGTM