lookup: skip platforms for serialport #994
Conversation
|
I confess I do not yet have visibility into where/how the integration tests for additional platforms are run. cc @Trott |
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #994 +/- ##
=======================================
Coverage 96.44% 96.44%
=======================================
Files 28 28
Lines 2139 2139
=======================================
Hits 2063 2063
Misses 76 76 ☔ View full report in Codecov by Sentry. |
This skips the remaining platforms that still pose a problem for verifying serialport against a `-pre` version of Node.js Relates to: nodejs#992
lib/lookup.json
Outdated
| @@ -420,6 +420,7 @@ | |||
| "comment": "postlint script fails" | |||
| }, | |||
| "serialport": { | |||
| "skip": ["aix", "s390x", "rhel"], | |||
There was a problem hiding this comment.
I think this will work:
| "skip": ["aix", "s390x", "rhel"], | |
| "skip": ["ppc", "s390x"], |
AIX in CI is ppc. rhel will skip rhel-x64 which is passing. I think we just want to skip ppc and s390x. (Skipping on processor type probably makes more sense here anyway, since it's a can't-compile-for-that-processor issue, I believe.)
There was a problem hiding this comment.
Thank you. Seeing both "aix", and "ppc" elsewhere in the lookup was a little confusing.
jeromecovington
force-pushed
the
skip-platforms-serialport
branch
from
96f5557
to
7d043a2
Compare
|
This worked! Hooray! Landing. |
This skips the remaining platforms that still pose a problem for verifying serialport against a
-preversion of Node.jsRelates to: #992
Checklist
npm testpasseshere