Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build,win: enable pch for clang-cl #55249

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

build,win: enable pch for clang-cl #55249

wants to merge 1 commit into from
+11 −11

Conversation

StefanStojanovic
Copy link
Contributor

This change improves ClangCL compilation time drastically by enabling PCH to be used.

Fixes: #55208

P.S. Since one of the changes is in the gyp-next I'll open a PR for it there as well.

@StefanStojanovic StefanStojanovic added windows Issues and PRs related to the Windows platform. build Issues and PRs related to build files or the CI. labels Oct 3, 2024
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/gyp
  • @nodejs/v8-update

@nodejs-github-bot nodejs-github-bot added gyp Issues and PRs related to the GYP tool and .gyp build files needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. v8 engine Issues and PRs related to the V8 dependency. labels Oct 3, 2024
@StefanStojanovic StefanStojanovic mentioned this pull request Oct 3, 2024
Merged
@codecov Codecov
Copy link

codecov bot commented Oct 3, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.40%. Comparing base (36ca010) to head (15bbc99).
Report is 53 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #55249   +/-   ##
=======================================
  Coverage   88.40%   88.40%           
=======================================
  Files         652      652           
  Lines      186573   186573           
  Branches    36045    36049    +4     
=======================================
+ Hits       164938   164944    +6     
- Misses      14903    14907    +4     
+ Partials     6732     6722   -10

see 41 files with indirect coverage changes

@StefanStojanovic StefanStojanovic added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 3, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 3, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/62908/

@nodejs-github-bot
Copy link
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2204-intel-64,v8test=v8test/6226/

@nodejs-github-bot
Copy link
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/6226/

@nodejs-github-bot
Copy link
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/6226/

@StefanStojanovic StefanStojanovic mentioned this pull request Oct 7, 2024
Closed
@anonrig anonrig requested a review from jasnell October 9, 2024 02:45
@StefanStojanovic StefanStojanovic added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anonrig anonrig anonrig approved these changes

@lemire lemire Awaiting requested review from lemire

@targos targos Awaiting requested review from targos

@richardlau richardlau Awaiting requested review from richardlau

@jasnell jasnell Awaiting requested review from jasnell

Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI. commit-queue Add this label to land a pull request using GitHub Actions. gyp Issues and PRs related to the GYP tool and .gyp build files needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. v8 engine Issues and PRs related to the V8 dependency. windows Issues and PRs related to the Windows platform.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve ClangCL compilation time on Windows.
3 participants
@StefanStojanovic @nodejs-github-bot @anonrig