Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add missing : to run()'s globPatterns #55135

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

RedYetiDev
Copy link
Member

I was looking over the documentation while working on adding run() coverage to nodejs/nodejs.org#7006, and I noticed that there is a missing :, so this quick PR fixes that.

Fast-tracking, as this change is a one character change to the documentation, and shouldn't have any negative side effects.

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/test_runner

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. test_runner Issues and PRs related to the test runner subsystem. labels Sep 26, 2024
@RedYetiDev RedYetiDev added the fast-track PRs that do not need to wait for 48 hours to land. label Sep 26, 2024
Copy link
Contributor

Fast-track has been requested by @RedYetiDev. Please 👍 to approve.

@RedYetiDev RedYetiDev added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 26, 2024
@lpinca lpinca added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 26, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 26, 2024
@nodejs-github-bot nodejs-github-bot merged commit ae82b45 into nodejs:main Sep 26, 2024
29 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in ae82b45

targos pushed a commit that referenced this pull request Oct 4, 2024
PR-URL: #55135
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
targos pushed a commit that referenced this pull request Oct 4, 2024
PR-URL: #55135
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@aduh95 aduh95 mentioned this pull request Oct 9, 2024
louwers pushed a commit to louwers/node that referenced this pull request Nov 2, 2024
PR-URL: nodejs#55135
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. test_runner Issues and PRs related to the test runner subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants