chore(eslint): remove typescript from base config

nodejs · Oct 18, 2024 · 0ad4e2e · 0ad4e2e
1 parent 17c883d
commit 0ad4e2e
Show file tree

Hide file tree

Showing 5 changed files with 306 additions and 5,545 deletions.
diff --git a/apps/site/eslint.config.js b/apps/site/eslint.config.js
@@ -1,4 +1,5 @@
 import { FlatCompat } from '@eslint/eslintrc';
+import importX from 'eslint-plugin-import-x';
 import * as mdx from 'eslint-plugin-mdx';
 import react from 'eslint-plugin-react';
 import storybook from 'eslint-plugin-storybook';
@@ -22,9 +23,17 @@ const compatConfig = compat.config({
 export default tseslint.config(
   ...baseConfig,
   {
-    extends: [react.configs.flat['jsx-runtime'], ...compatConfig],
+    extends: [
+      react.configs.flat['jsx-runtime'],
+      ...tseslint.configs.recommended,
+      importX.flatConfigs.typescript,
+      ...compatConfig,
+    ],
     files: ['**/*.{js,md,mdx,mjs,ts,tsx}'],
     rules: {
+      '@typescript-eslint/array-type': ['error', { default: 'generic' }],
+      '@typescript-eslint/consistent-type-imports': 'error',
+      '@typescript-eslint/no-require-imports': 'off',
       '@next/next/no-duplicate-head': 'off',
     },
     settings: {
@@ -48,7 +57,7 @@ export default tseslint.config(
   {
     files: ['**/*.{mdx,tsx}'],
     rules: {
-      // '@typescript-eslint/consistent-type-definitions': ['error', 'type'],
+      '@typescript-eslint/consistent-type-definitions': ['error', 'type'],
       'react/no-unescaped-entities': 'off',
       'react/function-component-definition': [
         'error',

diff --git a/eslint.config.js b/eslint.config.js
@@ -17,20 +17,12 @@ export default tseslint.config(
     ],
   },
   {
-    extends: [
-      js.configs.recommended,
-      importX.flatConfigs.recommended,
-      importX.flatConfigs.typescript,
-      ...tseslint.configs.recommended,
-    ],
+    extends: [js.configs.recommended, importX.flatConfigs.recommended],
     files: ['**/*.{js,mjs,ts,tsx}'],
     plugins: {
       'no-relative-import-paths': noRelativeImportPaths,
     },
     rules: {
-      '@typescript-eslint/array-type': ['error', { default: 'generic' }],
-      '@typescript-eslint/consistent-type-imports': 'error',
-      '@typescript-eslint/no-require-imports': 'off',
       'import-x/namespace': 'off',
       'import-x/no-named-as-default-member': 'off',
       'import-x/no-unresolved': 'off',