chore: self-code-review and adjustments

nodejs · Oct 30, 2023 · 22d12ce · 22d12ce
1 parent b89fc95
commit 22d12ce
Show file tree

Hide file tree

Showing 18 changed files with 21 additions and 22 deletions.
diff --git a/components/SideNavigation.tsx b/components/SideNavigation.tsx
@@ -27,14 +27,14 @@ const SideNavigation: FC<SideNavigationProps> = ({
   return (
     <nav aria-label="secondary">
       <ul>
-        {sideNavigationItems.map((item, key) => (
-          <li key={key} className={getLinkClasses(item.link, item.level)}>
+        {sideNavigationItems.map(item => (
+          <li key={item.key} className={getLinkClasses(item.link, item.level)}>
             <LocalizedLink href={item.link}>{item.text}</LocalizedLink>
 
             {item.items.length > 0 && (
               <ul>
-                {item.items.map(({ link, level, text }) => (
-                  <li key={link} className={getLinkClasses(link, level)}>
+                {item.items.map(({ link, level, text, key }) => (
+                  <li key={key} className={getLinkClasses(link, level)}>
                     <LocalizedLink href={link}>{text}</LocalizedLink>
                   </li>
                 ))}

diff --git a/i18n/locales/ar.json b/i18n/locales/ar.json
@@ -69,7 +69,7 @@
   "components.common.card.announcement": "Announcements",
   "components.common.card.release": "Releases",
   "components.common.card.vulnerability": "Vulnerabilities",
-  "components.home.homeDownloadButton.download": "Download {version} {isLts, select, true {lts} other {current}}",
+  "components.home.homeDownloadButton.download": "{version} {isLts, select, true {LTS} other {Current}}",
   "components.home.homeDownloadButton.tagline": "{isLts, select, true {Recommended For Most Users} other {Latest Features}}",
   "components.home.homeDownloadButton.changelog": "Changelog",
   "components.home.homeDownloadButton.otherDownloads": "Other Downloads",

diff --git a/i18n/locales/de.json b/i18n/locales/de.json
@@ -69,7 +69,7 @@
   "components.common.card.announcement": "Announcements",
   "components.common.card.release": "Releases",
   "components.common.card.vulnerability": "Vulnerabilities",
-  "components.home.homeDownloadButton.download": "Download {version} {isLts, select, true {lts} other {current}}",
+  "components.home.homeDownloadButton.download": "{version} {isLts, select, true {LTS} other {Current}}",
   "components.home.homeDownloadButton.tagline": "{isLts, select, true {Recommended For Most Users} other {Latest Features}}",
   "components.home.homeDownloadButton.changelog": "Changelog",
   "components.home.homeDownloadButton.otherDownloads": "Other Downloads",

diff --git a/i18n/locales/en.json b/i18n/locales/en.json
@@ -69,7 +69,7 @@
   "components.common.card.announcement": "Announcements",
   "components.common.card.release": "Releases",
   "components.common.card.vulnerability": "Vulnerabilities",
-  "components.home.homeDownloadButton.download": "Download {version} {isLts, select, true {lts} other {current}}",
+  "components.home.homeDownloadButton.download": "{version} {isLts, select, true {LTS} other {Current}}",
   "components.home.homeDownloadButton.tagline": "{isLts, select, true {Recommended For Most Users} other {Latest Features}}",
   "components.home.homeDownloadButton.changelog": "Changelog",
   "components.home.homeDownloadButton.otherDownloads": "Other Downloads",

diff --git a/i18n/locales/es.json b/i18n/locales/es.json
@@ -69,7 +69,7 @@
   "components.common.card.announcement": "Announcements",
   "components.common.card.release": "Releases",
   "components.common.card.vulnerability": "Vulnerabilities",
-  "components.home.homeDownloadButton.download": "Download {version} {isLts, select, true {lts} other {current}}",
+  "components.home.homeDownloadButton.download": "{version} {isLts, select, true {LTS} other {Current}}",
   "components.home.homeDownloadButton.tagline": "{isLts, select, true {Recommended For Most Users} other {Latest Features}}",
   "components.home.homeDownloadButton.changelog": "Changelog",
   "components.home.homeDownloadButton.otherDownloads": "Other Downloads",

diff --git a/i18n/locales/fr.json b/i18n/locales/fr.json
@@ -69,7 +69,7 @@
   "components.common.card.announcement": "Announcements",
   "components.common.card.release": "Releases",
   "components.common.card.vulnerability": "Vulnerabilities",
-  "components.home.homeDownloadButton.download": "Download {version} {isLts, select, true {lts} other {current}}",
+  "components.home.homeDownloadButton.download": "{version} {isLts, select, true {LTS} other {Current}}",
   "components.home.homeDownloadButton.tagline": "{isLts, select, true {Recommended For Most Users} other {Latest Features}}",
   "components.home.homeDownloadButton.changelog": "Changelog",
   "components.home.homeDownloadButton.otherDownloads": "Other Downloads",

diff --git a/i18n/locales/id.json b/i18n/locales/id.json
@@ -69,7 +69,7 @@
   "components.common.card.announcement": "Announcements",
   "components.common.card.release": "Releases",
   "components.common.card.vulnerability": "Vulnerabilities",
-  "components.home.homeDownloadButton.download": "Download {version} {isLts, select, true {lts} other {current}}",
+  "components.home.homeDownloadButton.download": "{version} {isLts, select, true {LTS} other {Current}}",
   "components.home.homeDownloadButton.tagline": "{isLts, select, true {Recommended For Most Users} other {Latest Features}}",
   "components.home.homeDownloadButton.changelog": "Changelog",
   "components.home.homeDownloadButton.otherDownloads": "Other Downloads",

diff --git a/i18n/locales/it.json b/i18n/locales/it.json
@@ -69,7 +69,7 @@
   "components.common.card.announcement": "Announcements",
   "components.common.card.release": "Releases",
   "components.common.card.vulnerability": "Vulnerabilities",
-  "components.home.homeDownloadButton.download": "Download {version} {isLts, select, true {lts} other {current}}",
+  "components.home.homeDownloadButton.download": "{version} {isLts, select, true {LTS} other {Current}}",
   "components.home.homeDownloadButton.tagline": "{isLts, select, true {Recommended For Most Users} other {Latest Features}}",
   "components.home.homeDownloadButton.changelog": "Changelog",
   "components.home.homeDownloadButton.otherDownloads": "Other Downloads",

diff --git a/i18n/locales/ja.json b/i18n/locales/ja.json
@@ -69,7 +69,7 @@
   "components.common.card.announcement": "Announcements",
   "components.common.card.release": "Releases",
   "components.common.card.vulnerability": "Vulnerabilities",
-  "components.home.homeDownloadButton.download": "Download {version} {isLts, select, true {lts} other {current}}",
+  "components.home.homeDownloadButton.download": "{version} {isLts, select, true {LTS} other {Current}}",
   "components.home.homeDownloadButton.tagline": "{isLts, select, true {Recommended For Most Users} other {Latest Features}}",
   "components.home.homeDownloadButton.changelog": "Changelog",
   "components.home.homeDownloadButton.otherDownloads": "Other Downloads",

diff --git a/i18n/locales/ka.json b/i18n/locales/ka.json
@@ -69,7 +69,7 @@
   "components.common.card.announcement": "Announcements",
   "components.common.card.release": "Releases",
   "components.common.card.vulnerability": "Vulnerabilities",
-  "components.home.homeDownloadButton.download": "Download {version} {isLts, select, true {lts} other {current}}",
+  "components.home.homeDownloadButton.download": "{version} {isLts, select, true {LTS} other {Current}}",
   "components.home.homeDownloadButton.tagline": "{isLts, select, true {Recommended For Most Users} other {Latest Features}}",
   "components.home.homeDownloadButton.changelog": "Changelog",
   "components.home.homeDownloadButton.otherDownloads": "Other Downloads",

diff --git a/i18n/locales/ko.json b/i18n/locales/ko.json
@@ -69,7 +69,7 @@
   "components.common.card.announcement": "Announcements",
   "components.common.card.release": "Releases",
   "components.common.card.vulnerability": "Vulnerabilities",
-  "components.home.homeDownloadButton.download": "Download {version} {isLts, select, true {lts} other {current}}",
+  "components.home.homeDownloadButton.download": "{version} {isLts, select, true {LTS} other {Current}}",
   "components.home.homeDownloadButton.tagline": "{isLts, select, true {Recommended For Most Users} other {Latest Features}}",
   "components.home.homeDownloadButton.changelog": "Changelog",
   "components.home.homeDownloadButton.otherDownloads": "Other Downloads",

diff --git a/i18n/locales/pt-br.json b/i18n/locales/pt-br.json
@@ -69,7 +69,7 @@
   "components.common.card.announcement": "Announcements",
   "components.common.card.release": "Releases",
   "components.common.card.vulnerability": "Vulnerabilities",
-  "components.home.homeDownloadButton.download": "Download {version} {isLts, select, true {lts} other {current}}",
+  "components.home.homeDownloadButton.download": "{version} {isLts, select, true {LTS} other {Current}}",
   "components.home.homeDownloadButton.tagline": "{isLts, select, true {Recommended For Most Users} other {Latest Features}}",
   "components.home.homeDownloadButton.changelog": "Changelog",
   "components.home.homeDownloadButton.otherDownloads": "Other Downloads",

diff --git a/i18n/locales/ru.json b/i18n/locales/ru.json
@@ -69,7 +69,7 @@
   "components.common.card.announcement": "Announcements",
   "components.common.card.release": "Releases",
   "components.common.card.vulnerability": "Vulnerabilities",
-  "components.home.homeDownloadButton.download": "Download {version} {isLts, select, true {lts} other {current}}",
+  "components.home.homeDownloadButton.download": "{version} {isLts, select, true {LTS} other {Current}}",
   "components.home.homeDownloadButton.tagline": "{isLts, select, true {Recommended For Most Users} other {Latest Features}}",
   "components.home.homeDownloadButton.changelog": "Changelog",
   "components.home.homeDownloadButton.otherDownloads": "Other Downloads",

diff --git a/i18n/locales/tr.json b/i18n/locales/tr.json
@@ -69,7 +69,7 @@
   "components.common.card.announcement": "Announcements",
   "components.common.card.release": "Releases",
   "components.common.card.vulnerability": "Vulnerabilities",
-  "components.home.homeDownloadButton.download": "Download {version} {isLts, select, true {lts} other {current}}",
+  "components.home.homeDownloadButton.download": "{version} {isLts, select, true {LTS} other {Current}}",
   "components.home.homeDownloadButton.tagline": "{isLts, select, true {Recommended For Most Users} other {Latest Features}}",
   "components.home.homeDownloadButton.changelog": "Changelog",
   "components.home.homeDownloadButton.otherDownloads": "Other Downloads",

diff --git a/i18n/locales/uk.json b/i18n/locales/uk.json
@@ -69,7 +69,7 @@
   "components.common.card.announcement": "Announcements",
   "components.common.card.release": "Releases",
   "components.common.card.vulnerability": "Vulnerabilities",
-  "components.home.homeDownloadButton.download": "Download {version} {isLts, select, true {lts} other {current}}",
+  "components.home.homeDownloadButton.download": "{version} {isLts, select, true {LTS} other {Current}}",
   "components.home.homeDownloadButton.tagline": "{isLts, select, true {Recommended For Most Users} other {Latest Features}}",
   "components.home.homeDownloadButton.changelog": "Changelog",
   "components.home.homeDownloadButton.otherDownloads": "Other Downloads",

diff --git a/i18n/locales/zh-cn.json b/i18n/locales/zh-cn.json
@@ -69,7 +69,7 @@
   "components.common.card.announcement": "Announcements",
   "components.common.card.release": "Releases",
   "components.common.card.vulnerability": "Vulnerabilities",
-  "components.home.homeDownloadButton.download": "Download {version} {isLts, select, true {lts} other {current}}",
+  "components.home.homeDownloadButton.download": "{version} {isLts, select, true {LTS} other {Current}}",
   "components.home.homeDownloadButton.tagline": "{isLts, select, true {Recommended For Most Users} other {Latest Features}}",
   "components.home.homeDownloadButton.changelog": "Changelog",
   "components.home.homeDownloadButton.otherDownloads": "Other Downloads",

diff --git a/i18n/locales/zh-tw.json b/i18n/locales/zh-tw.json
@@ -69,7 +69,7 @@
   "components.common.card.announcement": "Announcements",
   "components.common.card.release": "Releases",
   "components.common.card.vulnerability": "Vulnerabilities",
-  "components.home.homeDownloadButton.download": "Download {version} {isLts, select, true {lts} other {current}}",
+  "components.home.homeDownloadButton.download": "{version} {isLts, select, true {LTS} other {Current}}",
   "components.home.homeDownloadButton.tagline": "{isLts, select, true {Recommended For Most Users} other {Latest Features}}",
   "components.home.homeDownloadButton.changelog": "Changelog",
   "components.home.homeDownloadButton.otherDownloads": "Other Downloads",

diff --git a/styles/old/layout/main.css b/styles/old/layout/main.css
@@ -1,10 +1,9 @@
 #main {
   .container {
-    display: block;
+    display: flex;
   }
 
   .has-side-nav.container {
-    display: flex;
     flex-direction: row;
   }
 }