Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add codeql pipeline #5663

Closed
wants to merge 3 commits into from
Closed

add codeql pipeline #5663

wants to merge 3 commits into from

Conversation

UlisesGascon
Copy link
Member

Refs: #5659

@UlisesGascon UlisesGascon requested a review from a team as a code owner August 22, 2023 10:26
@vercel
Copy link

vercel bot commented Aug 22, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 31, 2023 8:19pm

@UlisesGascon UlisesGascon mentioned this pull request Aug 22, 2023
Closed
6 tasks
@github-actions
Copy link

github-actions bot commented Aug 22, 2023 •
edited
Loading

📦 Next.js Bundle Analysis for nodejs.org

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

ovflowd
ovflowd requested changes Aug 22, 2023
View reviewed changes
Copy link
Member

@ovflowd ovflowd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We already have CodeQL enabled by default.

@UlisesGascon
Copy link
Member Author

We already have CodeQL enabled by default.

Even if is enabled, it is recommended to include the pipeline.

Captura de pantalla 2023-08-22 a las 12 40 21

Current warnings

@ovflowd
Copy link
Member

ovflowd commented Aug 22, 2023

Gotcha. That makes sense. Can you add the missing EOF line?

@ovflowd
Copy link
Member

ovflowd commented Aug 22, 2023

@UlisesGascon can you checkout your branch locally and fix the linting issues?

@ovflowd
Copy link
Member

ovflowd commented Aug 26, 2023

Seems like CodeQL is failing.

@github-actions
Copy link

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 93%
 92.21% (367/398) 79% (79/100) 88.09% (74/84)

Unit Test Report

Tests Skipped Failures Errors Time
45 0 💤 0 ❌ 0 🔥 10.241s ⏱️

@UlisesGascon
Copy link
Member Author

I am researching about the error:

Error: Code Scanning could not process the submitted SARIF file:
CodeQL analyses from advanced configurations cannot be processed when the default setup is enabled

Seems like there is a misconfiguration. Maybe is related to github/codeql-action#1528.

Current config in Security tab 🤔

Captura de pantalla 2023-08-26 a las 16 25 41

@ovflowd
Copy link
Member

ovflowd commented Aug 31, 2023

@UlisesGascon are you going to fix this PR?

@ovflowd
Copy link
Member

ovflowd commented Sep 25, 2023

I'm closing this as a stale PR. Please feel free to reopen at your convenience.

@ovflowd ovflowd closed this Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ovflowd ovflowd ovflowd approved these changes

@aymen94 aymen94 aymen94 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@UlisesGascon @ovflowd @aymen94