-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: merged js logos and fixed svgs #5930
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
cc @nodejs/nodejs-website for fast-tracking. As these are trivial changes |
some of the newer issues reference |
I rather have them all on the same File but as different exports, as I've done with the logos |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
makes sense to me. thanks for this cleanup.
as a retro: we should have synced on how to structure this for GHC, but all in all it worked without too much trouble!
I agree, next time we should better sync this. |
This PR merges all the Node.js Logo variants in one file (and differentiates them by using different exports).
This PR also standardized the "Design System" Storybook Paths.
Finally, this PR fixes numerous SVGs by making them one-liners to avoid using extra network with line breaks.