Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: merged js logos and fixed svgs #5930

Merged
merged 1 commit into from
Oct 1, 2023

Conversation

ovflowd
Copy link
Member

@ovflowd ovflowd commented Oct 1, 2023

This PR merges all the Node.js Logo variants in one file (and differentiates them by using different exports).

This PR also standardized the "Design System" Storybook Paths.

Finally, this PR fixes numerous SVGs by making them one-liners to avoid using extra network with line breaks.

@ovflowd ovflowd added the fast-track Fast Tracking PRs label Oct 1, 2023
@vercel
Copy link

vercel bot commented Oct 1, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Oct 1, 2023 11:42am

@github-actions
Copy link

github-actions bot commented Oct 1, 2023

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 92%
90.24% (185/205) 75% (30/40) 86.66% (39/45)

Unit Test Report

Tests Skipped Failures Errors Time
14 0 💤 0 ❌ 0 🔥 3.24s ⏱️

@ovflowd
Copy link
Member Author

ovflowd commented Oct 1, 2023

cc @nodejs/nodejs-website for fast-tracking. As these are trivial changes

@bmuenzenmeyer
Copy link
Collaborator

some of the newer issues reference components/__design__/text.stories.tsx - so we will have to resolve where those go. perhap news files for each (list, anchor, inline code...) but text seemed convenient there

@ovflowd
Copy link
Member Author

ovflowd commented Oct 1, 2023

some of the newer issues reference components/__design__/text.stories.tsx - so we will have to resolve where those go. perhap news files for each (list, anchor, inline code...) but text seemed convenient there

I rather have them all on the same File but as different exports, as I've done with the logos

Copy link
Collaborator

@bmuenzenmeyer bmuenzenmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense to me. thanks for this cleanup.

as a retro: we should have synced on how to structure this for GHC, but all in all it worked without too much trouble!

@ovflowd
Copy link
Member Author

ovflowd commented Oct 1, 2023

makes sense to me. thanks for this cleanup.

as a retro: we should have synced on how to structure this for GHC, but all in all it worked without too much trouble!

I agree, next time we should better sync this.

@ovflowd ovflowd added this pull request to the merge queue Oct 1, 2023
Merged via the queue into main with commit 5fdaf73 Oct 1, 2023
19 checks passed
@ovflowd ovflowd deleted the meta/merged-nodejs-logos-fixed-svgs branch October 1, 2023 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fast-track Fast Tracking PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants