Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: apply eslint import rules on all js files #5932

Merged
merged 1 commit into from
Oct 1, 2023
Merged

chore: apply eslint import rules on all js files #5932

merged 1 commit into from
Oct 1, 2023

Conversation

ovflowd
Copy link
Member

@ovflowd ovflowd commented Oct 1, 2023

This PR simply applies the same import rules now on all JavaScript files

@vercel
Copy link

vercel bot commented Oct 1, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 1, 2023 3:12pm

@ovflowd ovflowd added fast-track Fast Tracking PRs github_actions:pull-request Trigger Pull Request Checks labels Oct 1, 2023
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Oct 1, 2023
@ovflowd
Copy link
Member Author

ovflowd commented Oct 1, 2023

cc @nodejs/nodejs-website for fast-tracking :)

@github-actions
Copy link

github-actions bot commented Oct 1, 2023

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 92%
 90.24% (185/205) 75% (30/40) 86.66% (39/45)

Unit Test Report

Tests Skipped Failures Errors Time
14 0 💤 0 ❌ 0 🔥 3.396s ⏱️

AugustinMauroy
AugustinMauroy approved these changes Oct 1, 2023
View reviewed changes
Copy link
Contributor

@AugustinMauroy AugustinMauroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ovflowd ovflowd added this pull request to the merge queue Oct 1, 2023
Merged via the queue into main with commit 4cdac87 Oct 1, 2023
18 of 19 checks passed
@ovflowd ovflowd deleted the chore/apply-eslint-rule-on-js-files-too branch October 1, 2023 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AugustinMauroy AugustinMauroy AugustinMauroy approved these changes

Assignees
No one assigned
Labels
fast-track Fast Tracking PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ovflowd @AugustinMauroy