Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create Notification Component #5955

Merged
merged 1 commit into from
Oct 6, 2023
Merged

Create Notification Component #5955

merged 1 commit into from
Oct 6, 2023

Conversation

fa-901
Copy link
Contributor

@fa-901 fa-901 commented Oct 2, 2023

Description

Created a Notification based on the requirements from the issue.

  • New directory added: Common/Notification
  • Added Radix Toast Provider & Viewportin preview.tsx
  • Added a Storybook file
  • Added styles based on Figma design with support for both light & dark themes

Note:

In Storybook, the component will appear at the bottom right of the viewport. So it will not be immediately visible, you just need to scroll down a bit 😊

Validation

image
image

Related Issues

Resolves 5948

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npx turbo lint to ensure the code follows the style guide. And run npx turbo lint:fix to fix the style errors if necessary.
  • I have run npx turbo format to ensure the code follows the style guide.
  • I have run npx turbo test to check if all tests are passing.
  • I've covered new added functionality with unit tests if necessary.

@fa-901 fa-901 requested a review from a team as a code owner October 2, 2023 21:06
@vercel
Copy link

vercel bot commented Oct 2, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 6, 2023 6:58pm

@mikeesto mikeesto added the github_actions:pull-request Trigger Pull Request Checks label Oct 3, 2023
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Oct 3, 2023
@github-actions
Copy link

github-actions bot commented Oct 3, 2023 •
edited
Loading

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 92%
 90.74% (196/216) 72.34% (34/47) 87.23% (41/47)

Unit Test Report

Tests Skipped Failures Errors Time
17 0 💤 0 ❌ 0 🔥 5.466s ⏱️

@mikeesto mikeesto added the github_actions:pull-request Trigger Pull Request Checks label Oct 3, 2023
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Oct 3, 2023
ovflowd
ovflowd reviewed Oct 3, 2023
View reviewed changes
.storybook/preview.tsx Outdated Show resolved Hide resolved
ovflowd
ovflowd approved these changes Oct 3, 2023
View reviewed changes
Copy link
Member

@ovflowd ovflowd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code-wise, LGTM! Waiting for that emitter, but thank you so much for your contribution!

Also if you could rebase the brabhc :)

ovflowd
ovflowd reviewed Oct 3, 2023
View reviewed changes
.storybook/preview.tsx Outdated Show resolved Hide resolved
ovflowd
ovflowd reviewed Oct 3, 2023
View reviewed changes
.storybook/preview.tsx Outdated Show resolved Hide resolved
@ovflowd ovflowd added the github_actions:pull-request Trigger Pull Request Checks label Oct 3, 2023
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Oct 3, 2023
@ovflowd ovflowd added the hacktoberfest This Issue is meant for Hacktoberfest 2023 label Oct 4, 2023
@fa-901 fa-901 requested a review from a team as a code owner October 4, 2023 17:38
ovflowd
ovflowd reviewed Oct 6, 2023
View reviewed changes
hooks/useNotification.ts Outdated Show resolved Hide resolved
@ovflowd ovflowd added the github_actions:pull-request Trigger Pull Request Checks label Oct 6, 2023
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Oct 6, 2023
ovflowd
ovflowd reviewed Oct 6, 2023
View reviewed changes
.storybook/preview.tsx Outdated Show resolved Hide resolved
ovflowd
ovflowd approved these changes Oct 6, 2023
View reviewed changes
Copy link
Member

@ovflowd ovflowd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff!

@ovflowd ovflowd added the github_actions:pull-request Trigger Pull Request Checks label Oct 6, 2023
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Oct 6, 2023
@ovflowd ovflowd added this pull request to the merge queue Oct 6, 2023
Merged via the queue into nodejs:main with commit 7e90b95 Oct 6, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikeesto mikeesto mikeesto left review comments

@ovflowd ovflowd ovflowd approved these changes

Assignees
No one assigned
Labels
hacktoberfest This Issue is meant for Hacktoberfest 2023
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create Notification Component
3 participants
@fa-901 @ovflowd @mikeesto