feat: InlineSelect ability #5963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ovflowd
requested changes
Oct 4, 2023
There was a problem hiding this comment.
Based on the figmas the icons should be bigger (https://www.figma.com/file/pu1vZPqNIM7BePd6W8APA5/Node.js?node-id=497%3A9542&mode=dev)
ovflowd
reviewed
Oct 4, 2023
ovflowd
reviewed
Oct 4, 2023
ovflowd
reviewed
Oct 4, 2023
ovflowd
reviewed
Oct 4, 2023
aymen94
approved these changes
Oct 5, 2023
|
@canerakdas the PR is still marked as draft, is there anything you want to change? |
github-actions
bot
removed
the
github_actions:pull-request
Unit Test Coverage Report
Unit Test Report
|
@ovflowd We use many styles in common with the Select component here, I want to double-check and make sure there is no styling I missed. |
github-actions
bot
removed
the
github_actions:pull-request
ovflowd
reviewed
Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
InlineSelectability added to theSelectcomponentValidation
Related Issues
fixes #5913
Check List
npx turbo lintto ensure the code follows the style guide. And runnpx turbo lint:fixto fix the style errors if necessary.npx turbo formatto ensure the code follows the style guide.npx turbo testto check if all tests are passing.