Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blog: v18.18.1 release post #5975

Merged
merged 1 commit into from
Oct 10, 2023
Merged

Blog: v18.18.1 release post #5975

merged 1 commit into from
Oct 10, 2023

Conversation

richardlau
Copy link
Member

Description

Release post for Node.js 18.18.1.

Validation

Blog post appears.

Related Issues

Refs: nodejs/node#50066

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npx turbo lint to ensure the code follows the style guide. And run npx turbo lint:fix to fix the style errors if necessary.
  • I have run npx turbo format to ensure the code follows the style guide.
  • I have run npx turbo test to check if all tests are passing.
  • I've covered new added functionality with unit tests if necessary.

@richardlau richardlau requested a review from a team as a code owner October 10, 2023 17:08
@vercel
Copy link

vercel bot commented Oct 10, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Oct 10, 2023 5:08pm

@github-actions
Copy link

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 94%
92.9% (262/282) 78.12% (50/64) 89.47% (51/57)

Unit Test Report

Tests Skipped Failures Errors Time
27 0 💤 0 ❌ 0 🔥 6.481s ⏱️

Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ovflowd
Copy link
Member

ovflowd commented Oct 10, 2023

@nodejs/releasers we require an approval from a releaser

@ovflowd ovflowd disabled auto-merge October 10, 2023 20:07
@ovflowd ovflowd added this pull request to the merge queue Oct 10, 2023
Merged via the queue into main with commit ce691f1 Oct 10, 2023
13 of 14 checks passed
@ovflowd ovflowd deleted the v18.18.1 branch October 10, 2023 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants