rename list and logos stories #5979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
removed
the
github_actions:pull-request
Unit Test Coverage Report
Unit Test Report
|
|
To be honest I think I always open the Storybook directly. This is the first time I've really looked closely at Chromatic's library page. I take your point though, it is a bit weird how it is currently grouped. I guess I don't have a strong opinion either way. I'll leave it to those who are using Chromatic in this way |
ovflowd
approved these changes
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Renamed two stories to better group the storybook design system.
Especially in Chromatic, the way they are currently named caused a strange grouping:
Only two
Others?
Validation
Before
After
One could argue that it looks better BEFORE, but I feel like it's oddly inconsistent with the other Design System stories and I'd rather we pick one pattern and go with it. I suppose, the crux of the problem is chormatics rendering, not local.
Chromatic... https://www.chromatic.com/library?appId=64c7d71358830e9105808652&branch=stories-fix
Is this better? Lemme know in the reviews - I won't be offended with "no" 😄
Related Issues
Check List
npx turbo lintto ensure the code follows the style guide. And runnpx turbo lint:fixto fix the style errors if necessary.npx turbo formatto ensure the code follows the style guide.npx turbo testto check if all tests are passing.