multiple storybook fixes and general enhancements #5991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
removed
the
github_actions:pull-request
Unit Test Coverage Report
Unit Test Report
|
github-actions
bot
removed
the
github_actions:pull-request
bmuenzenmeyer
approved these changes
Oct 12, 2023
mikeesto
approved these changes
Oct 12, 2023
|
merging - this is a minor and i'll consider it fast-tracked |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR does several minor adjustments to the Storybook experience, described as below:
baseUrlon ourtsconfig.jsonfilecolor-scheme: darkwhen our theme is dark and the same for light.next-themesbut since we don't use it within Storybook, as we simulate themes, we need to also simulate these styles.previewBodydirectly tomain.tsValidation
Storybook should still build and work as expected.