-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: updated release script and updated shiki #5997
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
cc @tniessen @nodejs/web-infra |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RSLGTM :)
309a47f
to
841a2fc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
read through it - also ran the current release post again
✅
The preview link is showing a 500 error? |
History is that we switched to using direct because of "Coming Soon"'s occurring: #4136 |
I'm guessing that's a hiccup - local and CI @ovflowd or someone else with Vercel access can look into it (I still do not) |
Right. But that's the source of flakiness. The thing is that |
Yea, I fixed the issue. It was Removing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Yes, being non-cached was the point behind the original switch. Maybe it's not an issue now with the tweaks that were made to avoid caching 404's. |
Right. I'll keep an eye on that once a next release is done! |
This reverts commit dafcdaa.
I'm releasing v21.1.0 and hit two "coming soon" links and no shasums in the generated changelog. |
Rerunning a couple times fixed it, but it seems that the warning that used to be printed is no longer here so this is prone to errors if the generated file is not verified. |
Heyo, 👋 which warnings? The rerunning is due to Cloudflare giving errors probably a cache purge happened recently. |
The script used to print warnings to the console when there were lines with "coming soon". |
It should still be doing that if the request failed. But I can double-check. Afaik if the request failed (i.e. it will trigger a coming soon) it should console.warn that it failed. Will give a double check over here. |
@richardlau also had two "coming soon" links. Did you see a warning? |
No, no warnings. |
Description
This PR cleans up and refactors the Node.js Release Blog Post generation script.
*
lists into-
lists (sadly prettier does not allow this to be changed)Validation
Generating the Blog Posts should still work (for latest version, specific version, and forced generation)