Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meta: updated next-intl and dependent packages #6130

Merged
merged 2 commits into from
Nov 19, 2023

Conversation

ovflowd
Copy link
Member

@ovflowd ovflowd commented Nov 17, 2023

Description

This PR updates our next-intl package to the official release of next-intl 3.0 (3.1.0) which also includes finally support for Turbopack on next-intl.

This PR pretty much updates dependencies for making that happen, and does some slight changes on next-intl config (i18n.tsx) (it also removes duplicated definitions of rich-text messages from DocsLayout and enables HMR for the English Language -- thanks to Turbopack)

Validation

All CI should work; Vercel deployment should work; i18n should work normally.

@ovflowd ovflowd added i18n Issues/PRs related to the Website Internationalisation infrastructure Issues/PRs related to the Repository Infra labels Nov 17, 2023
@ovflowd ovflowd requested a review from a team as a code owner November 17, 2023 23:43
Copy link

vercel bot commented Nov 17, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 19, 2023 4:33am

Copy link

github-actions bot commented Nov 17, 2023

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟢 100 🟢 97 🟠 83 🟢 92 🔗
/en/about 🟢 100 🟢 95 🟠 83 🟢 92 🔗
/en/about/previous-releases 🟢 100 🟢 96 🟠 83 🟢 92 🔗
/en/download 🟢 100 🟢 97 🟠 83 🟢 92 🔗
/en/blog 🟢 100 🟢 97 🟠 83 🟢 92 🔗

Copy link

github-actions bot commented Nov 17, 2023

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 87%
82.91% (398/480) 70.16% (87/124) 69.14% (65/94)

Unit Test Report

Tests Skipped Failures Errors Time
71 0 💤 0 ❌ 0 🔥 5.535s ⏱️

Copy link
Member

@canerakdas canerakdas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

i18n.tsx Outdated Show resolved Hide resolved
Signed-off-by: Brian Muenzenmeyer <[email protected]>
@bmuenzenmeyer bmuenzenmeyer added the github_actions:pull-request Trigger Pull Request Checks label Nov 19, 2023
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Nov 19, 2023
@bmuenzenmeyer bmuenzenmeyer added this pull request to the merge queue Nov 19, 2023
Merged via the queue into main with commit 6f85f19 Nov 19, 2023
15 checks passed
@bmuenzenmeyer bmuenzenmeyer deleted the meta/update-to-next-intl-31 branch November 19, 2023 04:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
i18n Issues/PRs related to the Website Internationalisation infrastructure Issues/PRs related to the Repository Infra
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants