fix(theme): Conform theme logic with OS theme preference #6138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
demakoff
commented
Nov 23, 2023
demakoff
commented
Nov 23, 2023
ovflowd
reviewed
Nov 23, 2023
ovflowd
approved these changes
Nov 23, 2023
github-actions
bot
removed
the
github_actions:pull-request
|
Lighthouse Results
|
Unit Test Coverage Report
Unit Test Report
|
bmuenzenmeyer
approved these changes
Nov 23, 2023
From the next-themes docs:
Talking about incorrect theme detection I have nothing to say 🤷🏻♂️ , if you have any details, let's consider 👍🏻 |
|
I'm fast-tracking this as a nice one-liner bug fix. |
|
Again, thank you for the contribution, @demakoff! Super appreciate it! |
|
@ovflowd Thanks a lot, Claudio 🤝 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It looks like after these changes in themeProvider.tsx initial conformity between app theme and OS theme preference was broken, so the app completely disregarded OS level theme user preference having a dark theme as default always.
Validation
Before:
After:
Related Issues
The issue was introduced here #6092
Check List
npx turbo lintto ensure the code follows the style guide. And runnpx turbo lint:fixto fix the style errors if necessary.npx turbo formatto ensure the code follows the style guide.npx turbo testto check if all tests are passing.