feat: introduced base website redesign layouts #6145
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ovflowd
added
website redesign
|
Note Your Pull Request seems to be updating Translations of the Node.js Website. Whilst we appreciate your intent; Any Translation update should be done through our Crowdin Project. Thank you! |
github-actions
bot
removed
the
github_actions:pull-request
|
Lighthouse Results
|
github-actions
bot
removed
the
github_actions:pull-request
Unit Test Coverage Report
Unit Test Report
|
hmm strange behaviour i spoke about the highight |
|
we can also remove |
|
also I don't saw on pr description why all locale files had ben remove. it's need for crowdin ? |
Right, the locales config files are created on Crowdin. |
That is expected. We don't have styling for Codeboxes yet on the redesign :) |
|
cc @nodejs/nodejs-website I need some extensive review here. Mostly on the layouts. I'm not sure if I'm adhering best practices for Tailwind and I might have also added one or two non-necessary styles. |
github-actions
bot
removed
the
github_actions:pull-request
ovflowd
force-pushed
the
feast/website-redesign-base-layouts
branch
from
ccfcbf5
to
5c87ae1
Compare
github-actions
bot
removed
the
github_actions:pull-request
|
Hey @nodejs/nodejs-website I'm still waiting for more reviews here :) this is a big change (but mostly doesn't affect the current website, by exception of the "Previous Releases" table. I would love more reviews here. (btw @canerakdas lmk if you feel the styles are 👌 by your standards 👀) |
github-actions
bot
removed
the
github_actions:pull-request
Description
This PR introduces a significant milestone to the Node.js Website Redesign; As we get closer to the release of the Node.js Website Redesign.
Ability to switch between Redesign <> Legacy
One of this Pull Request changes is introducing a new feature flag through an environment variable. It allows you to start Next.js on either serving with the Website Redesign Layouts or the Legacy Layouts.
The website redesign mode is primarily helpful for validating the implementation of layouts. You can now start a development mode for Website Redesign with
npm run serve:redesignornpx turbo serve:redesign.Updates on Shared Client Context
Our own in-house React Cache now also stores the reading time of a specific page (Markdown file) and the original filename (markdown file) besides the already existing context.
Updated Navigation Hooks
This Pull Request refactored how we store Navigation entries on
navigation.jsonby now separating them with "top navigation" and "side navigation" items. The usages and mapping and types also got refreshed and improved. The respective translations also got updated.Updated Redesign Components
Specific Website Redesign Components (such as
Select,MetaBar,SideBarand others) got updated to accommodate the needs of the Website Redesign better and got some design fixes.Introduction of the Base, Default, and Article Layouts
This Pull Request introduced the new Base Layout, Default Layout, Article Layout and About Layout for the Node.js Website Redesign.
These introduce base global style changes, introduce the layouts, their app-bounded logic and their respective "providers" that connect the "Common" generic components with real App-data.
These Layouts are pretty much ready, responsive and following all Figma specifications.
Validation
The Legacy Website should still work as expected. Locally the About and Get Involved pages should have finished Layouts for Website Redesign.