Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make headers on the website bold #6146

Merged
merged 2 commits into from
Nov 29, 2023
Merged

fix: make headers on the website bold #6146

merged 2 commits into from
Nov 29, 2023

Conversation

joyeecheung
Copy link
Member

@joyeecheung joyeecheung commented Nov 29, 2023

Description

This makes the posts more readable.

Validation

I didn't build the website locally but here is what I see in the browser when I applied changes to base.css.

Before (difficult to tell changes apart):

Screenshot 2023-11-29 at 15 31 00

After (easier):

Screenshot 2023-11-29 at 15 30 49

Related Issues

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npx turbo lint to ensure the code follows the style guide. And run npx turbo lint:fix to fix the style errors if necessary.
  • I have run npx turbo format to ensure the code follows the style guide.
  • I have run npx turbo test to check if all tests are passing.
  • I've covered new added functionality with unit tests if necessary.

This makes the posts more readable

Signed-off-by: Joyee Cheung <[email protected]>
@joyeecheung joyeecheung requested a review from a team as a code owner November 29, 2023 14:29
Copy link

vercel bot commented Nov 29, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 29, 2023 2:43pm

styles/old/base.css Outdated Show resolved Hide resolved
Copy link

github-actions bot commented Nov 29, 2023

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟢 94 🟢 97 🟢 92 🟢 92 🔗
/en/about 🟢 100 🟢 95 🟢 92 🟢 92 🔗
/en/about/previous-releases 🟢 98 🟢 93 🟢 92 🟢 92 🔗
/en/download 🟢 100 🟢 95 🟢 92 🟢 92 🔗
/en/blog 🟢 98 🟢 95 🟢 92 🟢 92 🔗

Copy link

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 94%
90.37% (366/405) 77.31% (92/119) 89.18% (66/74)

Unit Test Report

Tests Skipped Failures Errors Time
71 0 💤 0 ❌ 0 🔥 5.693s ⏱️

@ovflowd
Copy link
Member

ovflowd commented Nov 29, 2023

cc @nodejs/nodejs-website I'm fast-tracking this as a very simple change

@ovflowd ovflowd added this pull request to the merge queue Nov 29, 2023
Merged via the queue into main with commit 95100bd Nov 29, 2023
22 checks passed
@ovflowd ovflowd deleted the bold-headers branch November 29, 2023 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fast-track Fast Tracking PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants