meta: added million.js compiler (react) and updated packages #6475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
removed
the
github_actions:pull-request
|
Lighthouse Results
|
Unit Test Coverage Report
Unit Test Report
|
There was a problem hiding this comment.
Also you should use the For component.
it would certainly avoid this
Other point, you should add million in docs.
| @@ -127,10 +133,13 @@ const sentryConfig = { | |||
| // Next.js Configuration with `next.intl` enabled | |||
| const nextWithIntl = withNextIntl('./i18n.tsx')(nextConfig); | |||
|
|
|||
| // Enables Million.js React Compiler for Next.js | |||
| const nextWithMillion = million.next(nextWithIntl, { auto: true, rsc: true }); | |||
There was a problem hiding this comment.
Suggested change
| const nextWithMillion = million.next(nextWithIntl, { auto: true, rsc: true }); | |
| const nextWithMillion = million.next(nextWithIntl, { | |
| // support react server components | |
| auto: { rsc: true }, | |
| // We don't want to send telemetry data to Million | |
| telemetry: false, | |
| }); |
5 tasks
|
also strange behaviour search box is accessible by |
|
Well if this addition is not a drop-in placement then I don't think we should adopt the Million.js at the moment. I don't think that wrapping each iteration with this For component and other stuff is worth it. I don't want us to get dependent on yet another ecosystem. Im closing this |
|
ALSO, I assume this is the issue with Million.js duplicating and crashing: aidenybai/million#991 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the Million.js Compiler, which supposedly drastically reduces React's re-rendering times and complexity by "certain" bypasses of its reconciliation algorithm and another sort of magic.
This PR also updates all our packages to latest ✅ versions.