Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add docs for Proto package manager #6978

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ImBIOS
Copy link

@ImBIOS ImBIOS commented Aug 4, 2024

Description

This commit adds support for the Proto package manager in the site/types/release.ts, site/util/downloadUtils.ts, components/Downloads/Release/PlatformDropdown.tsx, and components/Icons/Platform/Proto.tsx files. The Proto package manager is now included as an option in the PackageManager enum and the platformItems array. The PlatformDropdown component has been updated to display the Proto icon. Additionally, the en.json file has been updated to include instructions for installing Proto.

Validation

image
image
image
image

Related Issues

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npm run format to ensure the code follows the style guide.
  • I have run npm run test to check if all tests are passing.
  • I have run npx turbo build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary.

This commit adds support for the Proto package manager in the site/types/release.ts, site/util/downloadUtils.ts, components/Downloads/Release/PlatformDropdown.tsx, and components/Icons/Platform/Proto.tsx files. The Proto package manager is now included as an option in the PackageManager enum and the platformItems array. The PlatformDropdown component has been updated to display the Proto icon. Additionally, the en.json file has been updated to include instructions for installing Proto.
@ImBIOS ImBIOS requested a review from a team as a code owner August 4, 2024 05:37
Copy link

vercel bot commented Aug 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Aug 4, 2024 5:39am

@ImBIOS ImBIOS changed the title feat: add support for Proto package manager docs: add docs for Proto package manager Aug 4, 2024
@bmuenzenmeyer
Copy link
Collaborator

bmuenzenmeyer commented Oct 8, 2024

#7037 will supersede this

Copy link
Member

@ovflowd ovflowd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, unfortunately, we are not accepting changes to the current Downloads page Codebox component. Read more here: #7037

Could you remove those changes from this PR? Thanks 🙏 (The i18n translation change is fine tho)

Copy link
Member

@avivkeller avivkeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Along with that @ovflowd said, I feel that this PR changes several different parts of the code. IMHO, each part should be split into a different PR, or at least a different commit (w/ drebase), to make understanding the file history easier.

@avivkeller
Copy link
Member

Also, there hasn't been any activity from the author in a little bit. If there's no activity in the next week (~4 months since open), I'm going to assume this stale-d and close it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants