Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add streams guide #7123

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
+883 −0
Open

feat: add streams guide #7123

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
55ff431
feat: add streams guide
Ceres6 Oct 16, 2024
09cc405
Merge branch 'main' into feat/stream-guide
ovflowd Oct 28, 2024
d13ac49
Apply suggestions from code review
Ceres6 Nov 14, 2024
5e4b3d7
Merge branch 'main' into feat/stream-guide
ovflowd Nov 16, 2024
8f76b2a
Apply suggestions from code review
Ceres6 Nov 17, 2024
0c3afaa
fixup! Apply suggestions from code review
Ceres6 Nov 17, 2024
6d9c6b4
fixup! fixup! Apply suggestions from code review
Ceres6 Nov 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions apps/site/navigation.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -328,6 +328,10 @@
"backpressuringInStreams": {
"link": "/learn/modules/backpressuring-in-streams",
"label": "components.navigation.learn.modules.links.backpressuringInStreams"
},
"howToUseStreams": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This learn page should be before backpressure in streams IMO.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll change it, I thought they needed to be in order of creation, but it makes sense to have this first as it is more basic/general

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

"link": "/learn/modules/how-to-use-streams",
"label": "components.navigation.learn.modules.links.howToUseStreams"
}
}
},
Expand Down
Loading
Loading