style: make sidebars sticky #7132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
I'm not sure that I like how the left sidebar is also sticky. It means we need to scroll down to the bottom of every page to see the Modules/Diagnostics/Test Runner pages. Would be interested to hear others thoughts |
ovflowd
requested changes
Oct 28, 2024
the original issue was just to put the ToC in sticky so that it's always handy in the desktop. Which I don't think is too bad, but I don't think the lef nav should be stiky. |
arthurjdam
force-pushed
the
style/make-sidebars-sticky
branch
from
034949b
to
3bad90e
Compare
|
That's fair. Updated to only make the Metabar sticky, but not the other bars |
github-actions
bot
removed
the
github_actions:pull-request
|
Lighthouse Results
|
ovflowd
approved these changes
Oct 31, 2024
Unit Test Coverage Report
Unit Test Report
|
|
Thanks for the contribution ✨ -- appreciate your time! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Make sidebars "sticky" to the browser top, making it accessible when scrolled partially or entirely down the page
Validation
When scrolling down the page, sidebars should remain visible:
On mobile, layout should be unaffected:
Related Issues
Addresses #7122
Check List
npm run formatto ensure the code follows the style guide.npm run testto check if all tests are passing.npx turbo buildto check if the website builds without errors.