Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

content/chore(learn): give visibility to the status page #7139

Merged
merged 2 commits into from
Oct 27, 2024

Conversation

AugustinMauroy
Copy link
Contributor

Description

Add status page on about and on the readme

Related Issues

Potential solution for #7050

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npm run format to ensure the code follows the style guide.
  • I have run npm run test to check if all tests are passing.
  • I have run npx turbo build to check if the website builds without errors.

@AugustinMauroy AugustinMauroy requested a review from a team as a code owner October 24, 2024 14:15
Copy link

vercel bot commented Oct 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Oct 25, 2024 8:06pm

Copy link
Collaborator

@bmuenzenmeyer bmuenzenmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tiny gramma nit

apps/site/pages/en/about/get-involved/contribute.md Outdated Show resolved Hide resolved
Co-authored-by: Brian Muenzenmeyer <[email protected]>
Signed-off-by: Augustin Mauroy <[email protected]>
Copy link
Member

@mikeesto mikeesto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

Copy link

github-actions bot commented Oct 27, 2024

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟢 95 🟢 100 🟢 100 🟢 91 🔗
/en/about 🟢 100 🟢 100 🟢 100 🟢 91 🔗
/en/about/previous-releases 🟢 100 🟢 100 🟢 100 🟢 92 🔗
/en/download 🟢 100 🟢 100 🟢 100 🟢 91 🔗
/en/blog 🟢 100 🟢 100 🟢 100 🟢 92 🔗

Copy link

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 92%
90.54% (594/656) 76.27% (180/236) 94.35% (117/124)

Unit Test Report

Tests Skipped Failures Errors Time
134 0 💤 0 ❌ 0 🔥 5.191s ⏱️

@mikeesto mikeesto added this pull request to the merge queue Oct 27, 2024
Merged via the queue into main with commit 32fd063 Oct 27, 2024
15 checks passed
@mikeesto mikeesto deleted the provide-visibility-status-page branch October 27, 2024 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants