adds link to github profile #7142
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
bmuenzenmeyer
commented
Oct 25, 2024
| @@ -11,16 +13,18 @@ export type AvatarProps = { | |||
|
|
|||
| const Avatar: FC<AvatarProps> = ({ src, alt, fallback }) => ( | |||
| <RadixAvatar.Root className={styles.avatarRoot}> | |||
There was a problem hiding this comment.
RadixAvatar.Root becomes a span. I don't think it matters from a DOM validation part which is outer-most - so I left Root, root. It also worked moving all the styles to the Link when I briefly had that as the root.
github-actions
bot
removed
the
github_actions:pull-request
|
Lighthouse Results
|
Unit Test Coverage Report
Unit Test Report
|
canerakdas
reviewed
Oct 25, 2024
| <RadixAvatar.Fallback delayMs={500} className={styles.avatar}> | ||
| {fallback} | ||
| </RadixAvatar.Fallback> | ||
| <Link href={`https://github.com/${alt}`}> |
There was a problem hiding this comment.
On some pages, such as /blog page, user names are sent as alt, this may cause incorrect links to be created 🤔
There was a problem hiding this comment.
good call. i think we should continue to pursue #7143 instead
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Authors are now GH links. currently this opens in the same tab. it could be enhanced to open elsewhere - but being a real, native link, the user has controls over that with mouse or keyboard controls
Validation
See the deployed preview https://nodejs-org-git-7141-author-link-openjs.vercel.app/en/learn/getting-started/introduction-to-nodejs
Related Issues
closes #7141
Check List
npm run formatto ensure the code follows the style guide.npm run testto check if all tests are passing.npx turbo buildto check if the website builds without errors.