Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve npm documentation for dependency management #7146

Merged
merged 3 commits into from
Oct 28, 2024

Conversation

Makena-Wambui
Copy link
Contributor

Enhanced the description of npm's functionality by specifying that it installs, updates, and manages dependencies. Added an explanation of dependencies, noting that they are pre-written pieces of code such as libraries and packages essential for a Node.js application to function.

@Makena-Wambui Makena-Wambui requested a review from a team as a code owner October 26, 2024 09:49
Copy link

vercel bot commented Oct 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Oct 28, 2024 3:00pm

Copy link
Member

@AugustinMauroy AugustinMauroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT !

Copy link
Collaborator

@bmuenzenmeyer bmuenzenmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Makena-Wambui !!

@aymen94
Copy link
Member

aymen94 commented Oct 28, 2024

@Makena-Wambui Congrats 😄, for you contribute.

Copy link
Contributor

github-actions bot commented Oct 28, 2024

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟢 96 🟢 100 🟢 100 🟢 91 🔗
/en/about 🟢 100 🟢 100 🟢 100 🟢 91 🔗
/en/about/previous-releases 🟢 99 🟢 100 🟢 100 🟢 92 🔗
/en/download 🟢 100 🟢 100 🟢 100 🟢 91 🔗
/en/blog 🟢 100 🟢 100 🟢 100 🟢 92 🔗

Copy link
Contributor

github-actions bot commented Oct 28, 2024

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 92%
90.54% (594/656) 76.27% (180/236) 94.35% (117/124)

Unit Test Report

Tests Skipped Failures Errors Time
134 0 💤 0 ❌ 0 🔥 5.051s ⏱️

@mikeesto
Copy link
Member

Thanks @Makena-Wambui . Can you run prettier to fix the formatting? Then we can merge this. Let me know if you have any problems

@Makena-Wambui
Copy link
Contributor Author

@mikeesto I ran Prettier, and it confirmed that no changes were needed.

@bmuenzenmeyer
Copy link
Collaborator

this isn't your fault at all, there was a bug in our scripting - i resolved within 3d144f7

@Makena-Wambui i tried pushing to your fork but could not. you can replicate the fix, sync/rebase, or otherwise we can troubleshoot further

@Makena-Wambui
Copy link
Contributor Author

@bmuenzenmeyer Please check if it is okay now.

…e-npm-package-manager.md

Signed-off-by: Brian Muenzenmeyer <[email protected]>
@bmuenzenmeyer
Copy link
Collaborator

bmuenzenmeyer commented Oct 28, 2024

yay - sorry this took so long @Makena-Wambui - it shouldn't be this hard (and that's on us)

@bmuenzenmeyer bmuenzenmeyer added this pull request to the merge queue Oct 28, 2024
Merged via the queue into nodejs:main with commit ccfd4b3 Oct 28, 2024
15 checks passed
@Makena-Wambui
Copy link
Contributor Author

Yay. Thank you so much. My first contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants