chore: upgrade to next 15 #7155

ovflowd · 2024-10-30T19:59:38Z

This PR attempts to upgrade to Next.js 15 with the following changes:

Updated also dependencies, such as next-intl to the latest version, which required refactoring on its usage for compliance
Updated all our dynamic segments and routes to be more performant (build only what is really needed in a minimal build, actually make it compatible with static exports)
- We avoid building OG on static exports as it is costly to compute. Static exports should simply not support OG images at the moment.
Updates usages of JSON imports to use with instead of assert
Updated all other dependencies and fixed issues as needed

vercel · 2024-10-30T19:59:43Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
nodejs-org	✅ Ready (Inspect)	Visit Preview	Nov 4, 2024 2:26pm

apps/site/util/downloadUtils.ts

github-actions · 2024-10-31T18:43:20Z

Running Lighthouse audit...

ovflowd · 2024-10-31T18:43:47Z

EDIT: it's work if you follow the next-intl docs

@AugustinMauroy Yep, switching to await requestLocale can help you to get rid of a Next.js 15 warning.

In combination, you probably want to adopt createNavigation here:

nodejs.org/apps/site/navigation.mjs

Lines 3 to 8 in 90afad3

import { createSharedPathnamesNavigation } from 'next-intl/navigation';

import { availableLocaleCodes } from './next.locales.mjs';

export const { Link, redirect, usePathname, useRouter } =

createSharedPathnamesNavigation({ locales: availableLocaleCodes });

These are the two changes that are relevant for next-intl to work with Next.js 15 without any warnings.

You might want to give the next-intl 3.22 release notes a look, I think there are other relevant deprecations that are relevant for this project.

Let me know if I can help with something!

@amannn thanks for the heads-up! I believe I've adjusted everything accordingly, feel free if you still have suggestions :)

eps1lon · 2024-10-31T20:36:47Z

We are getting so many ESlint errors like these, any ideas?

These look like TypeScript issues due to duplicate versions of @types/react.

ovflowd · 2024-10-31T20:44:53Z

We are getting so many ESlint errors like these, any ideas?

These look like TypeScript issues due to duplicate versions of @types/react.

I have the feeling something was wrong with the package-lock.json? Deleting the file, regenerating and running specifically:

rm package-lock.json
npm i --force
npm update --force --save

fixed all the issues (linting and builds are passing locally now)

ovflowd · 2024-10-31T20:46:23Z

Hmm, @amannn is there something wrong with our config? The build shows https://nodejs-org-git-chore-nextjs-15-openjs.vercel.app/en but running locally with npm run dev works (?) any clue from your side?

I also see that some translations (Header and Footer not working)

ovflowd · 2024-10-31T20:55:09Z

apps/site/app/[locale]/next-data/og/route.tsx

 // In this case we want to catch-all possible requests. This ensures that we always generate and
 // serve the OpenGrapgh images independently on the locale
 // @see https://nextjs.org/docs/app/api-reference/file-conventions/route-segment-config#dynamicparams
 export const dynamicParams = true;

 // Enforces that this route is used as static rendering
 // @see https://nextjs.org/docs/app/api-reference/file-conventions/route-segment-config#dynamic
-export const dynamic = ENABLE_STATIC_EXPORT ? 'force-static' : 'auto';
+export const dynamic = 'auto';


@bmuenzenmeyer we have an issue with this because this is the only endpoint failing build for static exports.

This endpoint is just incompatible with static exports. What now?

This should also mean this whole time OG generation was supposed to be broken for static exports... Which we shouldn't break.

What should we do here?

i see this had since changed - i am just now looking at it - lemme know if it's still a concern. the original implementation of next og work referenced tutorials that didn't really help much as it pertained to our combinations of use cases

It is still a concern.

cc @bmuenzenmeyer

thanks for fixing this!

ovflowd · 2024-11-04T13:18:31Z

Everything seems to be working right now except:

~~Internationalization (seems not to be kicking it. Able to reproduce on dev mode, and prod builds)~~
Storybook is not compatible with Next.js 15 yes, apparently, so we need to wait for them to update and be compatible.
Getting some warnings from Next.js on their route resolution

amannn · 2024-11-04T13:53:16Z

@ovflowd I had another look and found & fixed the issue here: #7178

I've also added a separate PR just for the next-intl update with minimal changes, in case you want to merge this part to main already: #7177

Hope this helps! 🙂

Co-authored-by: Claudio Wunder <[email protected]>

RedYetiDev · 2024-11-04T18:40:30Z

package.json

@@ -15,7 +15,7 @@
  "engines": {
    "node": "v20"


With this change, will Node.js >20 also be supported? IIRC the only issue was the with / assert?

Vercel just allow v20 for moment so I think we should stay on 20 for the moment.

This comment was marked as resolved.

Sign in to view

vercel bot had a problem deploying to Preview October 30, 2024 20:00 Failure

This comment was marked as resolved.

Sign in to view

AugustinMauroy reviewed Oct 30, 2024

View reviewed changes

apps/site/util/downloadUtils.ts Show resolved Hide resolved

This comment was marked as resolved.

Sign in to view

vercel bot had a problem deploying to Preview October 31, 2024 18:15 Failure

This comment was marked as resolved.

Sign in to view

ovflowd added the github_actions:pull-request Trigger Pull Request Checks label Oct 31, 2024

github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Oct 31, 2024

ovflowd had a problem deploying to Storybook October 31, 2024 18:43 — with GitHub Actions Failure

vercel bot had a problem deploying to Preview October 31, 2024 18:43 Failure

ovflowd added the github_actions:pull-request Trigger Pull Request Checks label Oct 31, 2024

github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Oct 31, 2024

ovflowd had a problem deploying to Storybook October 31, 2024 20:44 — with GitHub Actions Failure

vercel bot deployed to Preview October 31, 2024 20:44 View deployment

ovflowd marked this pull request as ready for review October 31, 2024 20:45

ovflowd requested review from a team as code owners October 31, 2024 20:45

ovflowd commented Oct 31, 2024

View reviewed changes

ovflowd added the github_actions:pull-request Trigger Pull Request Checks label Oct 31, 2024

ovflowd and others added 9 commits November 4, 2024 12:54

chore: upgrade to next 15

957da81

chore: fixed vars, next-intl, etc

e9bfadf

chore: more build fixes

77d6bd2

chore: fix dependencies

e0e7439

chore: some other issues on build

4b16b83

chore: fix unit tests

842a0f7

fix: Return locale in i18n.tsx, also move default there (#7157)

a586a85

chore: more refactor and bug fixing

6ec8094

chore: hydration warning

a6e17e4

ovflowd force-pushed the chore/nextjs-15 branch from 8a8d701 to a6e17e4 Compare November 4, 2024 12:56

ovflowd added the github_actions:pull-request Trigger Pull Request Checks label Nov 4, 2024

github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Nov 4, 2024

ovflowd deployed to Storybook November 4, 2024 12:56 — with GitHub Actions View deployment

chore: revert blog post

593c11f

ovflowd added the github_actions:pull-request Trigger Pull Request Checks label Nov 4, 2024

github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Nov 4, 2024

ovflowd deployed to Storybook November 4, 2024 12:57 — with GitHub Actions View deployment

vercel bot deployed to Preview November 4, 2024 13:00 View deployment

ovflowd mentioned this pull request Nov 4, 2024

[turbopack] issues with module resolution (warnings) since recent Next.js 14. vercel/next.js#71998

Open

amannn mentioned this pull request Nov 4, 2024

chore: Upgrade next-intl to 3.24, migrate deprecated APIs #7177

Open

5 tasks

amannn mentioned this pull request Nov 4, 2024

fix: Read locale from params in layout #7178

Merged

5 tasks

fix: Read locale from params in layout (#7178)

0049911

Co-authored-by: Claudio Wunder <[email protected]>

vercel bot deployed to Preview November 4, 2024 14:26 View deployment

ovflowd added the github_actions:pull-request Trigger Pull Request Checks label Nov 4, 2024

github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Nov 4, 2024

ovflowd deployed to Storybook November 4, 2024 14:26 — with GitHub Actions View deployment

bmuenzenmeyer mentioned this pull request Nov 4, 2024

[Bug]: Investigate Next.js v15 features storybookjs/storybook#29421

Open

5 tasks

RedYetiDev reviewed Nov 4, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: upgrade to next 15 #7155

chore: upgrade to next 15 #7155

ovflowd commented Oct 30, 2024 •

edited

Loading

vercel bot commented Oct 30, 2024 •

edited

Loading

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

github-actions bot commented Oct 31, 2024

ovflowd commented Oct 31, 2024

eps1lon commented Oct 31, 2024

ovflowd commented Oct 31, 2024

ovflowd commented Oct 31, 2024 •

edited

Loading

ovflowd Oct 31, 2024

ovflowd Oct 31, 2024

bmuenzenmeyer Nov 1, 2024

ovflowd Nov 1, 2024

ovflowd Nov 1, 2024

bmuenzenmeyer Nov 4, 2024

ovflowd commented Nov 4, 2024 •

edited

Loading

amannn commented Nov 4, 2024

RedYetiDev Nov 4, 2024

AugustinMauroy Nov 4, 2024

chore: upgrade to next 15 #7155

Are you sure you want to change the base?

chore: upgrade to next 15 #7155

Conversation

ovflowd commented Oct 30, 2024 • edited Loading

vercel bot commented Oct 30, 2024 • edited Loading

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

github-actions bot commented Oct 31, 2024

ovflowd commented Oct 31, 2024

eps1lon commented Oct 31, 2024

ovflowd commented Oct 31, 2024

ovflowd commented Oct 31, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ovflowd commented Nov 4, 2024 • edited Loading

amannn commented Nov 4, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ovflowd commented Oct 30, 2024 •

edited

Loading

vercel bot commented Oct 30, 2024 •

edited

Loading

ovflowd commented Oct 31, 2024 •

edited

Loading

ovflowd commented Nov 4, 2024 •

edited

Loading