-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(learn): add Package Configuration article #7229
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
OH idk if we can handle that with ou current infra |
It's an html tag. But I dunno how to include that via markdown. https://developers.google.com/search/docs/crawling-indexing/consolidate-duplicate-urls |
we already have that for lang |
Soooo… should I add something like
|
Sadly no because canonical for lang is handle by our i18n engine. |
the only front matter that learn section handle is: ---
title: A super cool title
layout: learn
authors: github_username, another_github_username
--- but why not open an issue if needed |
Thanks for picking it up! I won't have time to review this until ~December, so feel free to go ahead without my approval if you want to get it out soonish. But some observations after a quick glance, which I think should be addressed given that we spent hours at the summit talking about the issues with outdated content...:
|
@joyeecheung there was talk a while ago about discouraging |
Lighthouse Results
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have the feeling this article is not very beginner friendly and there are so many caveats and notes along the way that make it very hard to follow for someone who is not 100% into it
Thanks for the polish suggestions! I have a subsequent Learn article I need to write though, which depends on this. Could we set v1.0.0 goals for this article, and then subsequently improve it? |
I haven't heard anything in a few days, so I assume there are no more requests. I'm gonna merge. If there are others, please let me know and we can iterate on the article. |
This is an article I wrote a couple years ago. It's rather popular and addresses an issue @joyeecheung brought up at the collab summit.
I think canonical url needs to be set for SEO, so Google doesn't think it's plagiarised, but I don't know how to do that here.