Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update hardcoded nvm version #7323

Merged
merged 1 commit into from
Dec 9, 2024
Merged

Conversation

ljharb
Copy link
Member

@ljharb ljharb commented Dec 7, 2024

Description

Updates to the latest nvm version.

This is a temporary workaround until #7296 is figured out.

Validation

Go to the package manager download box. does the nvm URL say v0.40.1 instead of v0.40.0?

Related Issues

#7296.

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npm run format to ensure the code follows the style guide.
  • I have run npm run test to check if all tests are passing.
  • I have run npx turbo build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary.

@Copilot Copilot bot review requested due to automatic review settings December 7, 2024 22:14
@ljharb ljharb requested a review from a team as a code owner December 7, 2024 22:14
Copy link

vercel bot commented Dec 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Dec 7, 2024 10:15pm

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no suggestions.

Copy link
Member

@mikeesto mikeesto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

Copy link
Contributor

github-actions bot commented Dec 8, 2024

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 92%
90.79% (631/695) 72.44% (184/254) 94.53% (121/128)

Unit Test Report

Tests Skipped Failures Errors Time
143 0 💤 0 ❌ 0 🔥 4.952s ⏱️

@bmuenzenmeyer bmuenzenmeyer added this pull request to the merge queue Dec 9, 2024
Merged via the queue into nodejs:main with commit 8496897 Dec 9, 2024
16 checks passed
@ljharb ljharb deleted the update-nvm branch December 9, 2024 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants