Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(button): introduce size variant #7348

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

AugustinMauroy
Copy link
Member

Description

Adding small variant to the button component. It's will be used in the future for the download page to have a button kind of less agressive.

Validation

Default
Capture d’écran 2024-12-22 à 11 59 31

Small
Capture d’écran 2024-12-22 à 11 59 12

Related Issues

#7037 (comment)

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npm run format to ensure the code follows the style guide.
  • I have run npm run test to check if all tests are passing.
  • I have run npx turbo build to check if the website builds without errors.

@Copilot Copilot bot review requested due to automatic review settings December 22, 2024 11:00
@AugustinMauroy AugustinMauroy requested a review from a team as a code owner December 22, 2024 11:00
Copy link

vercel bot commented Dec 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Dec 22, 2024 11:08am

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.

Files not reviewed (1)
  • apps/site/components/Common/Button/index.module.css: Language not supported
Copy link
Contributor

github-actions bot commented Dec 22, 2024

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 89%
88.6% (583/658) 70.4% (176/250) 92.43% (110/119)

Unit Test Report

Tests Skipped Failures Errors Time
137 0 💤 0 ❌ 0 🔥 4.844s ⏱️

Copy link
Member

@ovflowd ovflowd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@canerakdas canerakdas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants