-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(InfoBox): introduce #7352
feat(InfoBox): introduce #7352
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Copilot
AI
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.
Files not reviewed (1)
- apps/site/components/ApiDocs/StabilityIndex/index.module.css: Language not supported
Signed-off-by: Augustin Mauroy <[email protected]>
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
Files not reviewed (1)
- apps/site/components/Common/InfoBox/index.module.css: Language not supported
Comments suppressed due to low confidence (4)
apps/site/components/Common/InfoBox/index.stories.tsx:12
- [nitpick] The title '3' is ambiguous. It should be renamed to a more descriptive title like 'Information'.
title: '3',
apps/site/components/Common/InfoBox/index.stories.tsx:22
- [nitpick] The title '2' is ambiguous. It should be renamed to a more descriptive title like 'Success'.
title: '2',
apps/site/components/Common/InfoBox/index.stories.tsx:32
- [nitpick] The title '1' is ambiguous. It should be renamed to a more descriptive title like 'Warning'.
title: '1',
apps/site/components/Common/InfoBox/index.stories.tsx:42
- [nitpick] The title '0' is ambiguous. It should be renamed to a more descriptive title like 'Error'.
title: '0',
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I sometimes fail to understand your review process. We discussed "Alert" as a component naming and then you go and name it "AlertBox" 😅 -- Anyhow, fair enough.
LGTM and thanks for implementing this :)
Description
we decided to make the
stabilityIndex
component a sub-component which is an InfoBox that can be used in the download page. also for thestabilityIndex
component it will just be a wrapper ofInfoBox
.Validation
It's should look like the Figma
https://www.figma.com/design/pu1vZPqNIM7BePd6W8APA5/Node.js?node-id=695-14399&t=aqPF3hoDGhAb29rs-1
Related Issues
#7037 (comment)
Check List
npm run format
to ensure the code follows the style guide.npm run test
to check if all tests are passing.npx turbo build
to check if the website builds without errors.