feat(icons): introduce package manager #7354
Open
+91
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-npm -pnpm -yarn
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
apps/site/components/Icons/PackageManager/Npm.tsx:11
- The attribute 'fill-rule' should be renamed to 'fillRule' to follow the camelCase convention in JSX.
<g fill="none" fill-rule="evenodd">
github-actions
bot
removed
the
github_actions:pull-request
Unit Test Coverage Report
Unit Test Report
|
ovflowd
reviewed
Dec 23, 2024
ovflowd
reviewed
Dec 23, 2024
ovflowd
reviewed
Dec 23, 2024
|
for size I use |
ovflowd
reviewed
Dec 24, 2024
| @@ -0,0 +1,24 @@ | |||
| import type { FC, SVGProps } from 'react'; | |||
|
|
|||
| /** | |||
There was a problem hiding this comment.
Why these @see statements? Are they really needed?
There was a problem hiding this comment.
We don't have'em in any of the other components, so let's keep it standard
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We will need these icons
Validation
It's shouldn't break trademark policy of theses projects
Check List
npm run formatto ensure the code follows the style guide.npm run testto check if all tests are passing.npx turbo buildto check if the website builds without errors.