Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!(deps): use .NET 8 libraries on netstandard2.0 #288

Merged
merged 3 commits into from
Mar 26, 2024
Merged

Conversation

nogic1008
Copy link
Owner

@nogic1008 nogic1008 commented Mar 26, 2024

This is a BREAKING CHANGE because System.Text.Json>=7.0.0 warns on .NET Core 3.1 or lower. (see dotnet/runtime#94327)

To suppress warning, you can add SuppressTfmSupportBuildWarnings on your csproj file.

Warning

This library does not been tested on .NET Core 3.1 or lower environments.
Be sure to integration test yourself.

<SuppressTfmSupportBuildWarnings>true</SuppressTfmSupportBuildWarnings>

@nogic1008 nogic1008 added this to the vNext milestone Mar 26, 2024
@nogic1008 nogic1008 added documentation 📝 Improvements or additions to documentation dependencies breaking changes 💥 labels Mar 26, 2024
Copy link

codecov bot commented Mar 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.94%. Comparing base (bda607d) to head (3e00b46).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #288   +/-   ##
=======================================
  Coverage   98.94%   98.94%           
=======================================
  Files           2        2           
  Lines          95       95           
  Branches        8        8           
=======================================
  Hits           94       94           
  Partials        1        1           
Flag Coverage Δ
Linux 98.83% <ø> (ø)
Windows 98.94% <ø> (ø)
macOS 98.83% <ø> (ø)
net48 98.88% <ø> (ø)
net6.0 98.83% <ø> (ø)
net8.0 98.83% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nogic1008 nogic1008 merged commit 8d78177 into main Mar 26, 2024
13 checks passed
@nogic1008 nogic1008 deleted the chore/deps branch March 26, 2024 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking changes 💥 dependencies documentation 📝 Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant