Change homepage links to the opendatahub website #399
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @henri-egger, again, very good job 👍 Unfortunately (for this PR) a redesign of the navigation is under process (see #204), I think that will also affect the links. In your opinion, should we leave this PR open to have the correct URLs somewhere, or should we close it? |
|
No problem, I think we might just want to leave the PR open, I will simply add the blocked badge to it. |
|
@gappc please merge |
|
Closing because changes in this PR are obsolete due to #429 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While testing the databrowser i saw that the two links regarding data sharing and data visualization at the bottom of the homepage were both directed to the opendatahub homepage, I talked to emily and we decided to change the links to point to the urls https://opendatahub.com/data-access and https://opendatahub.com/data-visualization.