-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nav footer redesign #409
Nav footer redesign #409
Conversation
@henri-egger nice work, thank you for this PR 👍 There are some small issues and since the PR touches the base layout, I think it would be best if we could have a meeting where we discuss the stuff. That way it's easier for me to explain some of the layout concepts and desired behavior. Maybe that could also be a chance that we can work out together some formalization of the layout and discuss other visualization issues e.g. as you already pointed out here #401 and here: #204 (comment) |
Good idea, will you organize the meeting? |
@gappc all changes we discussed today are now implemented, what's missing is:
I tried implementing the overlay using as little logic as possible, please look at it's implementation and tell me what you think. |
</footer> | ||
</ContentAlignmentX> | ||
| | ||
<ExternalLink href="/" tone="text">Privacy</ExternalLink> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Duplicate link to privacy?
@henri-egger really nice work, thank you to put such effort in the improvements and optimizations 👍 While this PR is already in good shape and almost ready to be merged, there remain some small issues:
Please note, that I will not be able to merge this PR during this week (I know it's your last week in this project at least for a while). There will be a productive deployment next Tuesday and I think it is better to give the changes in this PR some time in TEST environment before they are deployed to PROD. |
@gappc thanks ;). I will fix issues 1 and 2, issue 3 is the thing we already talked about in the meeting. I think as well that it will be best to ask the designers to come up with a solution which matteo can then implement. No problem regarding the release. Also, before this PR goes into prod, there needs to be a solution for z-indicies as it currently looks terrible on mobile when in table view with menu open. You might want to take a look at issue #401. |
@gappc I think everything on my part should be ok now. |
…ig variable; optimized header appearance
feat: added Testing page in header trough VITE_APP_ENV_BADGE env config; optimized header appearance
@gappc we reviewed the code included in this PR and now it seems that everything is OK, so we can merge this PR in the development branch to put all changes officially in testing. |
@gappc you can merge this |
Closing as rebased PR was merged in #429 |
@gappc
Here the PR for the new navigation and footer design.
Implementation Summary:
I will add the logic for te badge displaying the current environment once discussed here.