Add quarantine state #1
Conversation
Add quarantine state so symptomatic people can be isolated, revise prevention app simulation to quarantine people instead of stop them moving. If a symptomatic person has the app installed, all the people having the app which had contacts with him are quarantined as well.
There was a problem hiding this comment.
La funzione dichiarata nella descrizione è implementata bene a livello di codice e di logica, nulla da dire. Ben fatto.
Bisogna aumentare la minor versione sul package.json
A livello di algoritmo, paragonato alla precedente versione, il risultato cambia (mi sembra relativamente in peggio), ma per questo ci vorrebbe un Data Scientist che convalidi il modello ed esula dalla Review.
| @@ -25,16 +27,19 @@ export class Ball { | |||
| this.hasCollision = true | |||
| this.survivor = false | |||
| this.hasAppInstalled = hasAppInstalled | |||
| this.contacts = [] | |||
There was a problem hiding this comment.
Potresti auitarmi a capire contacts? Da quello che visto dal codice sarebbe un peopleEnteredInContact, corretto?
There was a problem hiding this comment.
yes, contact list like contact-tracing. It's the list of other balls this ball came in touch while it's sick.
| this.state = STATES.recovered | ||
| RUN.results[STATES.infected]-- | ||
| RUN.results[oldState]-- |
There was a problem hiding this comment.
Puo' essere un valore diverso da infected?
There was a problem hiding this comment.
infected or quarantine (see the if block above).
Changing the ball state to quarantine doesn't affect the time a person remains sick.
I made some double-checks on it. |
|
Please let's keep all the issues and PR requests in English to allow everybody to join our effor. |
|
Since this PR has been partially overtaken by PR #2 (merged), I would suggest to close it and file an issue to analyze if the "quarantine" state gives any improvement over "incubating" + "sick". |
If a symptomatic person has the app installed, all the people having the app which had contacts with him are quarantined as well.