Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retry requests on APIForbiddenError #1131

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Retry requests on APIForbiddenError #1131

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion kopf/_cogs/clients/api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,8 @@ async def request(
)
await errors.check_response(response) # but do not parse it!

except (aiohttp.ClientConnectionError, errors.APIServerError, asyncio.TimeoutError) as e:
# NOTE(vsaienko): during k8s upgrade API might throw 403 forbiden. Use retries for this exception as well.
except (aiohttp.ClientConnectionError, errors.APIServerError, asyncio.TimeoutError, errors.APIForbiddenError) as e:
if backoff is None: # i.e. the last or the only attempt.
logger.error(f"Request attempt {idx} failed; escalating: {what} -> {e!r}")
raise
Expand Down