Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export type helper function and type optimization #59

Merged
merged 13 commits into from
Jul 21, 2024
Merged

Conversation

nonzzz
Copy link
Owner

@nonzzz nonzzz commented Jul 17, 2024

CheckList

  • Export a helper function defineCompressionOption.
  • Type optimization.
  • Add type-check test for overload function.

Relative

#58

@mengdaoshizhongxinyang

@nonzzz nonzzz added the enhancement New feature or request label Jul 17, 2024
Copy link

codecov bot commented Jul 21, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 90.51%. Comparing base (5a16590) to head (f1147dd).
Report is 10 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##            master      #59      +/-   ##
===========================================
- Coverage   100.00%   90.51%   -9.49%     
===========================================
  Files            4        5       +1     
  Lines            4      527     +523     
  Branches         0      125     +125     
===========================================
+ Hits             4      477     +473     
- Misses           0       50      +50     
Files Coverage Δ
src/compress.ts 100.00% <100.00%> (ø)
src/shared.ts 100.00% <100.00%> (ø)
src/tar.ts 79.12% <100.00%> (ø)
src/task.ts 97.22% <100.00%> (-2.78%) ⬇️
src/index.ts 94.55% <57.14%> (-5.45%) ⬇️

@nonzzz nonzzz merged commit bf1f8ed into master Jul 21, 2024
20 of 21 checks passed
@nonzzz nonzzz deleted the feat/types branch July 21, 2024 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants